Repository navigation
Clean up comments and whitespace in src/; delete unused modules - #1952
Merged
rosethompson merged 9 commits intoOct 19, 2026
Merged
Conversation
Fix spelling, grammar, and wrong or garbled comments; normalize indentation and operator spacing; and add short comments explaining hard-to-follow control-bit logic, especially in the FPU. Code tokens are unchanged. Delete eight modules that are never instantiated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…dh/sv-cosmetics Resolve the src/cache/cache.sv conflict by taking openhwfoundation#1948's code (OFFSETLEN and SETLEN as parameters, NextSet sized OFFSETLEN+SETLEN) and keeping this branch's comment/whitespace cleanup. The NextSet comment no longer says "lower 12 bits", and the new localparams openhwfoundation#1948 added to ifu.sv and lsu.sv get aligned comments. After stripping comments and whitespace, every src/ file still matches main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: David Harris <David_Harris@hmc.edu>
Restore fdivsqrtuslc4, prioritythermometer, ram2p1r1wbe_128x64 and ram2p1r1wbe_2048x64 as they are on main, and put the two RAMs back in run_vcs's list of memories generated per FPGA target. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: David Harris <David_Harris@hmc.edu>
davidharrishmc
added a commit
to davidharrishmc/cvw
that referenced
this pull request
Oct 10, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Revert capitalization-only, punctuation-only, and no-gain rewording edits, restore contributors' informal notes, and keep commented-out code such as the rom1p1r bootloader initialization and the RAM preload blocks. Spelling fixes, corrections to wrong comments, added explanatory comments, and whitespace consistency stay. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
davidharrishmc
added a commit
to davidharrishmc/cvw
that referenced
this pull request
Oct 10, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Keep alternate designs, the ROM bootloader initialization, and optimization notes; drop superseded one-liners, dead predictor flops, and blocks that reference signals that no longer exist. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
davidharrishmc
added a commit
to davidharrishmc/cvw
that referenced
this pull request
Oct 10, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Conflicts were main's logic changes in lines this branch re-indented or re-commented; each keeps main's code with this branch's formatting: - fdivsqrtfsm.sv, div.sv: FlushE & ~StallM (openhwfoundation#1925) and its comment; the fdivsqrtfsm DONE-state exclusion tag stays removed - controller.sv: sfence.inval.ir refetch (openhwfoundation#1929) - tlbcamline.sv: TLBWrite/WritePTE_G/WritePTE_NAPOT ports (openhwfoundation#1927) - tlbcontrol.sv: ~UpperBitsUnequal in TLBMiss (openhwfoundation#1928), new BadNAPOT comment - csrc.sv: time/timeh read only with Zicntr (openhwfoundation#1951) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Harris <David_Harris@hmc.edu>
# Conflicts: # src/hazard/hazard.sv # src/privileged/csr.sv # src/privileged/privdec.sv
Contributor
Author
|
Merge order: this is part of the cosmetic stack, merged strictly #1952 → #1955 → #1959 so each delta shows on its own. Merge the open bug-fix PRs first: #1949, #1958, #1967, #1969, #1972, #1982, #1986 and #1987. The stack conflicts textually with them, and re-applying formatting is easier than re-applying fixes. 🤖 Generated with Claude Code |
Contributor
|
I am still in the process of reviewing but there are several merge conflicts. |
Signed-off-by: David Harris <David_Harris@hmc.edu> # Conflicts: # src/fpu/fctrl.sv # src/fpu/postproc/fmashiftcalc.sv # src/fpu/postproc/postprocess.sv # src/ifu/bpred/RASPredictor.sv # src/ifu/bpred/bpred.sv # src/ifu/bpred/icpred.sv # src/ifu/ifu.sv # src/ifu/spill.sv # src/lsu/align.sv # src/lsu/lsu.sv # src/privileged/csrm.sv # src/uncore/uartPC16550D.sv
Restore the original fdivsqrtiter comment and shiftcorrection operand alignment, use single spaces between the aes64d/aes64e module and instance names, push every ieu.sv comment out one column so the PrivilegedM comment lines up, list hptw's TerapageMisaligned before GigapageMisaligned, and align every NextWalkerState assignment in the hptw FSM. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Harris <David_Harris@hmc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment and whitespace cleanup across
src/:After stripping comments and whitespace, every file's code is identical to main except one
bmuctrldefault literal whose digit grouping changed (same value). TheGetLineNumtargets incoverage-exclusions-rv64gc.dostill resolve to the same lines.Also deletes modules that are never instantiated:
arrs,trickbox_apb,aesmixcolumns8androtate.🤖 Generated with Claude Code