20260930 - Stop offering the notch filters as settings - #106
Merged
Merged
Conversation
The DAB and RF notch checkboxes on the Configuration page no longer did anything. retina-node's config-merger now derives capture.device.dabNotch and rfNotch from the final capture.fc (a notch is on unless the capture band overlaps its stopband, RF 77-115 MHz and DAB 155-235 MHz) and overwrites whatever user.yml holds, so a value saved from the form was silently ignored. The fields are removed from CaptureFormConfig, from the capture flatten/unflatten mapping, and from the unchecked-checkbox defaulting in parse_flat_form_data, so saving the form never writes the notch keys. A user.yml that still holds them is left alone: the merger overwrites them and the next Save drops them. docs/features/config-editor.md gains a Notch filters section, including a warning that a node tuned inside a stopband gets a stronger signal once its notch turns off, so gain set with the notch on may overload until it is recalibrated. docs/features/auto-calibrate.md notes that a live retune changes fc but not the notches, so a candidate in a different notch band is probed with the wrong notches until /calibrate/apply restarts blah2. A new test in test_app.py checks that saving the form, with notch keys already in user.yml and stale notch fields posted, writes neither key. The full suite passes, as do ruff and the dead-code gate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "DAB Notch Filter" and "RF Notch Filter" checkboxes are removed from the Configuration page.
Why
offworldlabs/retina-node#46 makes config-merger derive
capture.device.dabNotchandrfNotchfrom the finalcapture.fc(a notch is on unless the capture band overlaps its stopband: RF 77-115 MHz, DAB 155-235 MHz), and it overwrites whateveruser.ymlholds. A value saved from the form would be silently ignored.Fix
CaptureFormConfiglosesdevice_dabNotchanddevice_rfNotch.parse_flat_form_datadrop them, so saving the form never writes the notch keys.user.ymlthat still holds them is left alone: the merger overwrites them and the next Save drops them.vulture_whitelist.pyloses the two entries.Testing
ruff check .and the dead-code gate pass.test_save_does_not_write_notch_filters: with notch keys already inuser.ymland stale notch fields posted, neither key is written./opt/retina-gui./configrendered with no notch fields and the other capture fields intact, and Apply ran through todone. The node was restored afterwards.Docs
docs/features/config-editor.md: new "Notch filters" section (derived fromfc, not user settings, old keys harmless, and a warning that a node tuned inside a stopband may overload until recalibrated). The Capture row and the form-parsing paragraph are updated.docs/features/auto-calibrate.md: new "Notch filters are not retuned" subsection. A live retune changesfcbut not the notches.After this
Merge together with offworldlabs/retina-node#46. On its own this only removes two checkboxes whose values the current merger still honours.
🤖 Generated with Claude Code