Repository navigation
20261005 - Say what each notch filter blocks and when to leave it on - #109
Merged
Merged
Conversation
The DAB and RF Notch Filter checkboxes on the Configuration page both said only "Not recommended to enable unless you are sure", which told an owner nothing about what they do. Both are on by default, so the text also pointed the wrong way. Each now says the band it blocks (DAB 155-235 MHz, covering DAB and VHF TV; RF 77-115 MHz, FM radio), to leave it on unless the node's tower is in that band, and to recalibrate after changing it. That last part matters because switching a notch changes the received signal by roughly 20-30 dB for a tower inside its band, so gain calibrated with the notch in one state can overload the radio in the other. Text only: no defaults, logic or form behaviour change. docs/ needs no update, as config-editor.md lists the capture fields but not their help text. The full suite passes, as do ruff and the dead-code gate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The DAB and RF Notch Filter checkboxes on the Configuration page get useful help text. Both used to say "Not recommended to enable unless you are sure", which told an owner nothing about what they do. Both are on by default, so the text also pointed the wrong way.
Why
The bands come from the SDRplay spec. The recalibrate warning comes from a test node whose tower sits inside the DAB band. Switching that notch off raised its signal by roughly 20-30 dB, and gain calibrated with the notch on overloaded the radio. This replaces the reverted approach of deriving the notches automatically (#106, reverted in #108).
Text only: no defaults, logic or form behaviour change.
Testing
ruff check .and the dead-code gate pass. No test asserted the old text.Docs
No
docs/change needed:docs/features/config-editor.mdlists the capture fields but not their help text.After this
offworldlabs/blah2-arm#78 fixes the matching rspduo README wording.
🤖 Generated with Claude Code