Repository navigation
20261005 - Bring back the notch filter settings on the Configuration page - #108
Merged
Merged
Conversation
…page This reverts #106 (merge b58ae53) in full, restoring the DAB Notch Filter and RF Notch Filter checkboxes. #106 removed them because retina-node was deriving both from the centre frequency, and that change is being reverted too. The notches are being redone as better help text on these same checkboxes instead. The revert is exactly #106 undone. #107 has since changed docs/features/config-editor.md and tests/test_app.py, and its changes are kept. The full suite passes, as do ruff and the dead-code gate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #106 (merge
b58ae53) in full.Why
The notch filter work is being redone differently: the DAB and RF notches stay user settings, and only their descriptions on retina-gui's Configuration page change. No config-merger logic.
Verification
docs/features/config-editor.mdandtests/test_app.py, where 20261002 - Tell the owner what to do when the radio stops sending data #107's later changes are kept, unchanged.ruff check .and the dead-code gate pass.config-editor.mdandauto-calibrate.mdare removed with it.After this
Merge alongside offworldlabs/retina-node's revert of #46. The new notch descriptions follow in a separate PR.
🤖 Generated with Claude Code