Skip to content

Add a searchable composer emoji picker - #161

Merged
nixfred merged 1 commit into
nixfred:mainfrom
marcus:upstream-emoji-picker
Nov 10, 2026
Merged

nixfred merged 1 commit into
nixfred:mainfrom
marcus:upstream-emoji-picker

Conversation

@marcus

@marcus marcus commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Fourth standalone split from #156, on main 3795d64. A smiley button beside Send opens a searchable Unicode catalogue with categories and keyboard navigation. Choosing an emoji replaces the current selection or inserts at the caret, then restores composer focus without sending. Escape preserves the draft.

No new bridge tool, permission or setting. Keeps upstream’s theme, composer and manifest. The composer picker is independent of custom reactions; its licensed catalogue data is identical to the reactions PR’s shared catalogue. Most added lines are catalogue data and its generated QML module.

Validation: 808 Bun tests, all 22 Python bridge suites referenced by CI, and 6 QtTest checks against the actual composer/popup pass. Inspected the synthetic popup screenshot and rendered the shipping app with invented demo data; runtime log has no scene errors. See docs/emoji-picker.md.

Search Unicode names and categories and replace the current selection without sending. Keep drafts in memory and return editor focus when the popup closes. Include licensed catalogue data, a generated QML module and real composer keyboard regression coverage; leave bridge behavior and app styling intact.
@marcus
marcus requested a review from nixfred as a code owner November 10, 2026 04:19
@nixfred
nixfred merged commit 0d302b1 into nixfred:main Nov 10, 2026
1 check passed
nixfred added a commit that referenced this pull request Nov 10, 2026
…ll 4x faster (CHANGELOG, CHANGE.log, roster, weekly notes)

WHAT: CHANGELOG entries for #158 (Delivered until Read) and #161 (composer emoji picker) with the real end-to-end numbers for the poll speed-up (shallow 0.77 s to 0.2 s, deep 2.1 s to 1.0 s on gus); CHANGE.log entries for 401b99d, #158 and #161; Marcus Vorwaller added to the no-X table in CONTRIBUTORS-X.md (nothing on his GitHub profile or social accounts, his site marcus.pictures lists none, checked 10 Nov); WEEKLY-NOTES W46 section for 10 Nov with Marcus's own words about the rebases and the reasons #159 #160 #162 #163 were sent back.
WHY: the PR-run checklist records every merge the day it lands, with the contributor's real name and a verified X handle or a visible "none found" plus asking Fred the same day.
CONTEXT: independent review of #159 #160 #162 #163 (read-only, nothing sent to the Mac) found: #162 ffmpeg guessed the format from sender bytes (reproduced: a two-line ffconcat file delivered as a video rendered a different cached picture), #163 Qt plays bytes the safety check never saw and playback stops on any list rebuild, #160 three failure paths after Return report "nothing sent" and the recipient is never checked before Return (both confirmed against the code), #159 the shipped macOS 27 path has no test. Comments with the specifics are on each PR. Deployed 10 Nov to the gateway Mac (read_state.py and imsg, backups in ~/.blip/backups-20261110), gus and vic, all healthy, no log errors.
TAGS: docs, changelog, change-log, weekly-notes, roster, marcus, pr-run, review

LR-T: pr-run, contributor-pr, bookkeeping
LR-D: blip, docs
LR-K: pr-158-161-merged, pr-159-160-162-163-sent-back, marcus-no-x
LR-R: 401b99d, ea64c98, 0d302b1

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
@nixfred

nixfred commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Merged (main 0d302b1), and thank you, Marcus. I rendered it in a clean Omarchy VM on invented data: the popup follows the theme, the search field, category list and grid all work, and keeping the grid virtualized over a plain array is the right call for a catalogue this size. Insert-at-caret, replace-selection, focus returning to the composer without sending, and Escape keeping the draft are the details that make a picker feel native.

One small thing for later, not a blocker: one cell drew as an empty box in the VM, an emoji newer than that image's emoji font. If you ever want to polish it, hiding glyphs the font cannot draw would avoid the blank cell.

You are credited in the changelog and the weekly notes (no X account found for you; send the handle if you want to be tagged).


Generated by Claude Code

nixfred added a commit that referenced this pull request Nov 10, 2026
… (CHANGELOG, CHANGE.log, roster, weekly notes, CLAUDE.md)

WHAT: CHANGELOG and CHANGE.log entries for #162 (native stickers) and the reaction-scan speed-up (9b4f8d9) with the real numbers; CONTRIBUTORS-X.md moves Marcus Vorwaller to 3 merged (#158, #161, #162), still no X handle found and asked Fred; WEEKLY-NOTES W46 gets the #162 and speed-up bullets plus the note that #159, #160 and #163 got a second independent review of their rebased heads; CLAUDE.md's measured-latency paragraph gains the lesson from the reaction scan (the 90-day margin is real data: 3 of 28,305 reactions are stamped before their target, the worst by 0.83 days; an ORDER BY in SQL brings the full scan back; the date index reorders reactions unless sorted by ROWID; do not probe the guid index by shape because _strip_assoc is lenient on purpose).
WHY: the PR-run checklist records every merge the day it lands, and the next agent that "optimises" enrich() must find the traps written down instead of rediscovering them.
CONTEXT: Fred approved the #162 merge and the speed-up from the literal diffs on 10 Nov. Merge commit aee3394, speed-up 9b4f8d9.
TAGS: docs, changelog, change-log, weekly-notes, roster, claude-md, pr-run, stickers, latency

LR-T: pr-run, bookkeeping, latency
LR-D: blip, docs
LR-K: pr-162-merged, tapback-window-bound, marcus-no-x
LR-R: aee3394, 9b4f8d9

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
nixfred added a commit that referenced this pull request Nov 11, 2026
WHAT: the same-turn bookkeeping for the #159 merge (6a4fbce, 56bc294).
  - CHANGELOG.md: a proper Unreleased entry; the one-line note Marcus's rebase
    left above the "## Unreleased" heading is removed (it was orphaned there).
  - CHANGE.log: #159 entry with the live 27.2 proof and what Larry added.
  - CONTRIBUTORS-X.md: Marcus 5 merged (#158 #161 #162 #163 #159), #160 under
    review, X handle still none found (rechecked 2026-11-11, asked Fred).
  - WEEKLY-NOTES.md: W46 Wed 11 Nov, #159 bullet and the two Blip-side findings.
NOT staged on purpose: bridge/mac/findmy_city.py and test_findmy_city.py are
  someone else's uncommitted work in this tree.

LR-T: blip, pr-159, changelog, contributors, weekly-notes
LR-D: blip, docs
LR-K: pr-run-bookkeeping
LR-R: 6a4fbce, 56bc294

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants