Repository navigation
Add opt-in native replies with confirmed-send safeguards - #160
Conversation
|
Thank you, Marcus. Native replies are the feature people ask about most, and the safeguards are the right ones: text on stdin on both machines and never in argv, set through the accessibility value without touching the clipboard, off by default behind Blocking
Should fix
Smaller notes: What I will do. Once 1 to 3 are in, I will run it on the real macOS 27.2 gateway, on the self-thread only, because how long Messages takes to clear the field and whether Generated by Claude Code |
…ll 4x faster (CHANGELOG, CHANGE.log, roster, weekly notes) WHAT: CHANGELOG entries for #158 (Delivered until Read) and #161 (composer emoji picker) with the real end-to-end numbers for the poll speed-up (shallow 0.77 s to 0.2 s, deep 2.1 s to 1.0 s on gus); CHANGE.log entries for 401b99d, #158 and #161; Marcus Vorwaller added to the no-X table in CONTRIBUTORS-X.md (nothing on his GitHub profile or social accounts, his site marcus.pictures lists none, checked 10 Nov); WEEKLY-NOTES W46 section for 10 Nov with Marcus's own words about the rebases and the reasons #159 #160 #162 #163 were sent back. WHY: the PR-run checklist records every merge the day it lands, with the contributor's real name and a verified X handle or a visible "none found" plus asking Fred the same day. CONTEXT: independent review of #159 #160 #162 #163 (read-only, nothing sent to the Mac) found: #162 ffmpeg guessed the format from sender bytes (reproduced: a two-line ffconcat file delivered as a video rendered a different cached picture), #163 Qt plays bytes the safety check never saw and playback stops on any list rebuild, #160 three failure paths after Return report "nothing sent" and the recipient is never checked before Return (both confirmed against the code), #159 the shipped macOS 27 path has no test. Comments with the specifics are on each PR. Deployed 10 Nov to the gateway Mac (read_state.py and imsg, backups in ~/.blip/backups-20261110), gus and vic, all healthy, no log errors. TAGS: docs, changelog, change-log, weekly-notes, roster, marcus, pr-run, review LR-T: pr-run, contributor-pr, bookkeeping LR-D: blip, docs LR-K: pr-158-161-merged, pr-159-160-162-163-sent-back, marcus-no-x LR-R: 401b99d, ea64c98, 0d302b1 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
8b61245 to
6ff4b26
Compare
|
Addressed the review and rebased onto current main.
Validation: 832 Bun tests, 352 synthetic Mac Python tests, and the reply-banner Qt checks passed. No real conversations were opened or replies sent. CI is running. This still needs your planned macOS 27.2 self-thread validation, especially the title shape; no broad compatibility claim is intended. |
6ff4b26 to
ed13570
Compare
… (CHANGELOG, CHANGE.log, roster, weekly notes, CLAUDE.md) WHAT: CHANGELOG and CHANGE.log entries for #162 (native stickers) and the reaction-scan speed-up (9b4f8d9) with the real numbers; CONTRIBUTORS-X.md moves Marcus Vorwaller to 3 merged (#158, #161, #162), still no X handle found and asked Fred; WEEKLY-NOTES W46 gets the #162 and speed-up bullets plus the note that #159, #160 and #163 got a second independent review of their rebased heads; CLAUDE.md's measured-latency paragraph gains the lesson from the reaction scan (the 90-day margin is real data: 3 of 28,305 reactions are stamped before their target, the worst by 0.83 days; an ORDER BY in SQL brings the full scan back; the date index reorders reactions unless sorted by ROWID; do not probe the guid index by shape because _strip_assoc is lenient on purpose). WHY: the PR-run checklist records every merge the day it lands, and the next agent that "optimises" enrich() must find the traps written down instead of rediscovering them. CONTEXT: Fred approved the #162 merge and the speed-up from the literal diffs on 10 Nov. Merge commit aee3394, speed-up 9b4f8d9. TAGS: docs, changelog, change-log, weekly-notes, roster, claude-md, pr-run, stickers, latency LR-T: pr-run, bookkeeping, latency LR-D: blip, docs LR-K: pr-162-merged, tapback-window-bound, marcus-no-x LR-R: aee3394, 9b4f8d9 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
|
Second-round review of ed13570, thank you for the fast turnaround. An independent reviewer went through it read-only (nothing sent to a Mac); I re-ran the main blocker and checked the others in the code. Fixed and confirmed
Blocker 1: the PR breaks tapbacks that work on main today. Blocker 2: my first blocker is only half fixed on the Linux side. Should-fix
Still unproven (needs the gateway Mac, self-thread only, with Fred's explicit word): what Messages' window title looks like on 27.2 and whether a sheet shows while the reply view is open, whether
|
472d6da to
d0fc54f
Compare
WHAT: the same-turn bookkeeping for the #159 merge (6a4fbce, 56bc294). - CHANGELOG.md: a proper Unreleased entry; the one-line note Marcus's rebase left above the "## Unreleased" heading is removed (it was orphaned there). - CHANGE.log: #159 entry with the live 27.2 proof and what Larry added. - CONTRIBUTORS-X.md: Marcus 5 merged (#158 #161 #162 #163 #159), #160 under review, X handle still none found (rechecked 2026-11-11, asked Fred). - WEEKLY-NOTES.md: W46 Wed 11 Nov, #159 bullet and the two Blip-side findings. NOT staged on purpose: bridge/mac/findmy_city.py and test_findmy_city.py are someone else's uncommitted work in this tree. LR-T: blip, pr-159, changelog, contributors, weekly-notes LR-D: blip, docs LR-K: pr-run-bookkeeping LR-R: 6a4fbce, 56bc294 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Third-round check of d0fc54f. This time I ran the checks myself on your head, no independent reviewer yet: that full read waits for the rebase, because the code that ships is what is left after it. #159 and #163 are both merged. Fixed and confirmed (I ran each)
Still open
Still unproven, needs the real 27.2 gateway, self-thread only, with Fred's explicit word (I send nothing without it): what Messages' window title looks like on 27.2 and whether a sheet shows while the reply view is open, whether Thank you for the quick turnaround on the blockers. After the rebase I will do the full independent review and the live checks. Generated by Claude Code |
Gate native replies behind replies=on and confirm one Return through chat.db. Keep uncertain sends visible and never restore text unless the exit code proves a refusal; preserve newer drafts and bar-owned reply jobs. Rebase onto current upstream reactions and audio, keeping shared AX helpers and permission fixes intact. Regenerate the QML module and execute draft, recipient and target guards before any write; mutations of all four review gaps fail the tests. Preserve upstream UI, manifest, stdin transport and synthetic-only validation.
d0fc54f to
bfaa399
Compare
|
Fourth-round review of bfaa399, thank you for the rebase onto #159 and #163. This is the full read I promised, by an independent reviewer (read-only, nothing sent to any Mac), plus my own mechanical checks. There is no blocker and the Mac side is in good shape. I will merge once the four items below are fixed and the live checks are done. Fixed since last round and confirmed
To fix before merge
Small UX item (safe): some provably-before-the-Mac failures say "Delivery unconfirmed" and keep the words: shim exit 78, a process that never starts ( Live checks (mine, with Fred's word, self-thread only; nothing runs until he says so): the window title shape for a contact, a bare number, an email and the self-thread, and whether a sheet shows while the reply view is open; what Escape does with text in the reply field; whether setting the field value then Return sends exactly that text (line breaks, emoji) and how long the field takes to clear; picture discovery and labels; how slow the checks are on a long conversation against the 45 s timeout; whether replying marks the conversation read. Generated by Claude Code |
Treat signalled helpers as uncertain, reserve a distinct local not-started result, and refuse later twins before touching Messages. Require the focused reply field to retain the exact body before Return. Add synthetic regression and mutation coverage for the reviewed send guards; preserve the no-automatic-resend invariant.
WHAT: entries for Marcus Vorwaller's opt-in native replies (#160, merge e7ac796), his roster count (6 merged, no X account, credit by GitHub handle), W46 Sat. WHY: same-turn bookkeeping for a merge; four review rounds, all fixed. NOT DONE: live send on the 27.2 gateway, which needs Fred's explicit word. LR-T: blip, pr-160, changelog, contributors, weekly-notes LR-D: blip, docs LR-K: pr-160-merged-bookkeeping Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
|
Merged as e7ac796. Thank you, Marcus: four rounds in five days, and every point answered in code within hours. Native replies are a big addition and you kept the safety model intact the whole way. What I checked on 6634bdf before merging: all four round-4 items are fixed (a signal-killed helper now counts as unconfirmed, twins are refused before Messages is touched, the focused field must hold the exact text before Return, the never-started helper has its own sentinel). I broke each new guard on purpose, ten ways, and every break failed a test. CI is green, It stays off by default ( Generated by Claude Code |
…t label Jason Alexander's fix for a contact texting on RCS while the chat row still said iMessage (every send left as iMessage and died with error 22). The send service now comes from the opened conversation's own rows via threadSendService, with SMS only ever on phone numbers and short codes, groups never carrying --service, and an RCS business agent exception. Conflicts with #160 (BlipView.qml send block, SendState.mjs, send-state.test.ts) resolved here because pushes to contributor forks are blocked by the Law 11 guard: kept #165's sendServiceFor and #160's Date.now()-based localId, kept both sides' tests, regenerated SendState.mjs with the command in send-state.ts. Checked on 3a13a27 merged with main: bun 927 pass, send-service/reply/read/ reaction QtTest scripts pass, generated module identical to the generator, gitleaks clean. NOT yet proven on a real Android RCS contact through the 27.2 gateway. LR-T: blip, pr-165, send-service, rcs, merge LR-D: blip LR-K: send-service-from-conversation-rows LR-L: law-11 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v68N3DWV2UhtuJggZz
…d voice messages WHAT: Unreleased becomes 2.7.0 (2026-11-17) with a short "Before you update" block on top (re-run blip-setup on the Mac, the optional ffmpeg and Qt6 packages for voice and stickers, the opt-in keys replies=on, tapbacks=on and shared_city=on, and the two things not yet proven live). manifest.json and the README version badge go 2.6.2 -> 2.7.0, and the README test badge goes 790 -> 927 passing, the real count. The CHANGELOG heading uses hyphens, not the em-dashes of the older headings, because Fred's no-em-dash rule covers every file; the version-agreement test only needs "## 2.7.0" at the line start. WHY: Fred, 2026-11-17: asked to consider a 2.7.0 release, was shown the readiness check (200 commits from 22 people and 42 merged PRs since 2.6.2, all of it already written up under Unreleased, no open PRs), then ordered the official release. 2.6.2 (26 Sep) was the latest release for seven weeks. VERIFIED: bun test on gus at c95b556, the tree before this commit: 927 pass, 0 fail. HEAD, origin/main and forgejo/main were all c95b556 and gh listed no open PRs. The ui.test.ts version-agreement test passes with the three files in step, and gitleaks found nothing in the diff. The suite on the larry VM shows one failure only because ffmpeg is not installed there (audio-waveform.test.ts shells out to it); gus has ffmpeg and is clean. OPEN: a send to a real RCS contact through the Mac (#165) and a native reply on a 27.2 gateway (#160) are not proven live; both are said so in the notes. CONTEXT: staged by path, the three release files only. TRIAGE-2026-10-02.md and pitch_deck_content.md are untracked and not part of the release. LR-T: blip, release, 2.7.0, changelog, version, contributors LR-D: blip, release, github LR-K: blip-2-7-0-release-2026-11-17, blip-release-after-2-6-2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v3LkbABkmYshbwkWb6
…ger say the release is open) WHAT: CHANGE.log gets the 2.7.0 release entry (newest first, feeds X-POSTS.md): tag v2.7.0 on 9fe5d98, the headline PRs, the 21 outside contributors thanked by handle, Erik Fillipsveen named, and the two things not proven live (#165 on a real RCS contact, #160 on a 27.2 gateway). WEEKLY-NOTES.md W47 loses the line "A release is Fred's call", which stopped being true when Fred ordered it, and records the release instead, with a note that the post for it names Erik. WHY: the notes are written the day the work lands, and a notes file that still says the release is open sends the next run off to ask Fred again. VERIFIED: docs only, two files staged by path; gitleaks clean on the diff. The release itself was verified in 9fe5d98: bun test on gus 927 pass 0 fail, origin and forgejo main and the peeled v2.7.0 tag all at 9fe5d98, the GitHub release live and marked Latest, raw manifest.json on main says 2.7.0. OPEN: the 2.7.0 announcement post is not written; Fred posts, Larry drafts. LR-T: blip, release, 2.7.0, change-log, weekly-notes, w47 LR-D: blip, docs, release LR-K: blip-2-7-0-release-2026-11-17, blip-release-after-2-6-2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v3LkbABkmYshbwkWb6
replies=onenables native Reply for supported direct-message text and single pictures; it is off by default. Quote and reply remains available. The dispatcher, installer and Linux shim explicitly gate the newimsg-replytool.Before Return, the tool refuses a Mac draft and requires matching recipient window title, reply target text/time, front app, reply-field identity and exact focused-field contents. Targets with later identical labels at the same HH:MM are refused before opening Messages. Text travels on stdin and is filled through AX without the clipboard. After one Return, chat.db must confirm the outgoing thread. Unconfirmed sends, signal/crash exits and transport/software failures say to check Messages and never automatically hand the words back. Local shim refusal (78) and a distinct never-started sentinel safely restore words; Mac EX_SOFTWARE (70) remains uncertain. BarWidget owns reply jobs and result context across view closure.
Based on current upstream main (
69ca3ab), including merged #159 reactions and #163 audio. Preserves upstream theme, controls and manifest; no upstream file deletions. Uses main's shared NativeAX, picker routing, cleanup helpers and permission fixes.Validation on
6634bdf: 894 Bun tests and every Python/Qt step from CI pass; shell syntax, shellcheck and pyflakes on imsg-react, imsg-reply and blip-dispatch pass. MessageActions and TapbackActions rebuild byte-identically; SendState is regenerated. Synthetic tests cover the fourth-round review's final target/front/focus/placeholder checks, focused-field text, label time, missing Reply transcript, script exceptions, confirmation text and picture-with-balloon refusal. All 11 targeted guard mutations fail tests. No real conversations opened or messages sent.The recipient-title shape and live macOS behavior still need the maintainer's planned validation. Unsupported title shapes fail closed. Details and limitations are in
docs/replies.md.