Repository navigation
Play voice messages inline with real waveforms and seeking - #163
Conversation
|
Thank you, Marcus. Inline players with a measured waveform, seeking and exactly one voice playing at a time are a real step up from opening mpv, and the in-memory analysis with no PCM sidecar is the right shape. The review of this branch found three blocking problems, all about what happens after the checks pass, plus some smaller ones. Blocking
Should fix
Tests that do not fail when the safeguard goes. Each of these one-line changes left the suite green: the decoded-duration check set to Order. #162 conflicts with this branch in the attachment chip and Generated by Claude Code |
…ll 4x faster (CHANGELOG, CHANGE.log, roster, weekly notes) WHAT: CHANGELOG entries for #158 (Delivered until Read) and #161 (composer emoji picker) with the real end-to-end numbers for the poll speed-up (shallow 0.77 s to 0.2 s, deep 2.1 s to 1.0 s on gus); CHANGE.log entries for 401b99d, #158 and #161; Marcus Vorwaller added to the no-X table in CONTRIBUTORS-X.md (nothing on his GitHub profile or social accounts, his site marcus.pictures lists none, checked 10 Nov); WEEKLY-NOTES W46 section for 10 Nov with Marcus's own words about the rebases and the reasons #159 #160 #162 #163 were sent back. WHY: the PR-run checklist records every merge the day it lands, with the contributor's real name and a verified X handle or a visible "none found" plus asking Fred the same day. CONTEXT: independent review of #159 #160 #162 #163 (read-only, nothing sent to the Mac) found: #162 ffmpeg guessed the format from sender bytes (reproduced: a two-line ffconcat file delivered as a video rendered a different cached picture), #163 Qt plays bytes the safety check never saw and playback stops on any list rebuild, #160 three failure paths after Return report "nothing sent" and the recipient is never checked before Return (both confirmed against the code), #159 the shipped macOS 27 path has no test. Comments with the specifics are on each PR. Deployed 10 Nov to the gateway Mac (read_state.py and imsg, backups in ~/.blip/backups-20261110), gus and vic, all healthy, no log errors. TAGS: docs, changelog, change-log, weekly-notes, roster, marcus, pr-run, review LR-T: pr-run, contributor-pr, bookkeeping LR-D: blip, docs LR-K: pr-158-161-merged, pr-159-160-162-163-sent-back, marcus-no-x LR-R: 401b99d, ea64c98, 0d302b1 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
6eb5fce to
bc6af69
Compare
|
Addressed the review and rebased onto current main. Qt now plays only a generated, private 24 kHz mono PCM WAV, built from bounded decoding through the explicit input demuxer. It never receives the original container. The normalized WAV doubles as a content-hash analysis cache, participates in LRU accounting, and preserves source originals for Save. Recordings exceeding the ten-minute normalization budget use the external fallback rather than a truncated inline timeline. The view owns the optional multimedia Loader independently of message delegates. Attachment cards are lazy-loaded without a QtMultimedia import, and missing multimedia falls back to an ordinary chip plus external Open/Save. Model rebuilds preserve the active player's position; closing/leaving stops it. Audio is no longer auto-fetched/analyzed on thread open: a play click requests it. Added AMR, AIFF and WebM recognition; missing tools or unavailable normalization can use external mpv with the explicit recognized demuxer. Setup treats multimedia as optional and mentions mpv. Tests now assert the decode-duration check and actual Validation: 829 Bun tests, 323 synthetic Mac Python tests, 7 real WAV/Qt playback checks and 13 session checks passed; rendered controls inspected. No real conversations were opened. CI is running. I have not measured decoder behavior inside a live bar; click-only normalization and the optional loader reduce that exposure, while the live-shell measurement remains unclaimed. I'll rebase over #162 when it lands, per your order. |
|
Three small things I left out of the review above, so you can take them in the same pass:
And Generated by Claude Code |
bc6af69 to
d968ff6
Compare
… (CHANGELOG, CHANGE.log, roster, weekly notes, CLAUDE.md) WHAT: CHANGELOG and CHANGE.log entries for #162 (native stickers) and the reaction-scan speed-up (9b4f8d9) with the real numbers; CONTRIBUTORS-X.md moves Marcus Vorwaller to 3 merged (#158, #161, #162), still no X handle found and asked Fred; WEEKLY-NOTES W46 gets the #162 and speed-up bullets plus the note that #159, #160 and #163 got a second independent review of their rebased heads; CLAUDE.md's measured-latency paragraph gains the lesson from the reaction scan (the 90-day margin is real data: 3 of 28,305 reactions are stamped before their target, the worst by 0.83 days; an ORDER BY in SQL brings the full scan back; the date index reorders reactions unless sorted by ROWID; do not probe the guid index by shape because _strip_assoc is lenient on purpose). WHY: the PR-run checklist records every merge the day it lands, and the next agent that "optimises" enrich() must find the traps written down instead of rediscovering them. CONTEXT: Fred approved the #162 merge and the speed-up from the literal diffs on 10 Nov. Merge commit aee3394, speed-up 9b4f8d9. TAGS: docs, changelog, change-log, weekly-notes, roster, claude-md, pr-run, stickers, latency LR-T: pr-run, bookkeeping, latency LR-D: blip, docs LR-K: pr-162-merged, tapback-window-bound, marcus-no-x LR-R: aee3394, 9b4f8d9 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
|
Second-round review of d968ff6, thank you for the fast turnaround. An independent reviewer went through the new head read-only (nothing sent to a Mac), and I re-ran the blocker myself. Three of the four original points are fixed in code; one is not. Fixed and confirmed
Blocker: Qt still plays bytes the sender controls
Should-fix (from the independent review; I did not re-run these)
Nits: without QtMultimedia the first Play click does nothing visible; a file name of about 66 to 75 CJK characters makes the temporary WAV name too long; Order is unchanged: #163 is next after #162, which is now merged. You will hit conflicts in |
d968ff6 to
6458ce0
Compare
… 11 Nov, #163 merged WHAT: two tests and the same-turn bookkeeping for the #163 merge. - audio-waveform.test.ts: a cache hit must hand Qt the WAV Blip generated (a .pcm2- file, same URL as the first analysis), never the received file, and must run neither ffprobe nor ffmpeg. - ui.test.ts: the mpv fallback keeps its demuxer named (--demuxer=lavf --demuxer-lavf-format=<format>) and "--" before the path. WHY: mutation check on #163's head, 7 guard mutations: 4 failed a test, these 2 (cache hit returning the original file's URL; mpv format no longer forced) plus the cache owner check left everything green. Both now fail a test (verified: M5, M7 and dropping "--" each give 1 fail). The owner check needs a file owned by another uid, so root; left as is. DOCS: CHANGELOG.md, CHANGE.log, CONTRIBUTORS-X.md (Marcus 4 merged, X still none found, rechecked 11-11), WEEKLY-NOTES.md W46 Wed 11 Nov. VERIFIED: bun test 872 pass. LR-T: blip, pr-163, audio, tests, mutation-testing, changelog, contributors LR-D: blip, tests, docs LR-K: cache-hit-serves-generated-wav, mpv-forced-demuxer-test LR-R: e2dd817 LR-L: law-10, law-11, law-14 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
|
Merged as e2dd817. Thank you, Marcus: three rounds in a day, and every point answered in code, not in words. Voice messages playing inside Blip with a real waveform is a big one. What I checked on 0a20ad5 before merging:
One small follow-up I did myself (dee1ac1): of 7 guard mutations, 4 now fail your tests. Two of the survivors are cheap to cover, so I added tests: a cache hit must hand Qt the generated Nits from round 2 that are still open, none blocking, take them or leave them: without QtMultimedia the first Play click does nothing visible; "Loading…" never shows while a play request is queued; "one voice at a time" holds per view, not across the panel and the window; the mpv command lost Next in the queue are #159 and then #160. Both need a live check on the real 27.2 gateway (self-thread only) once Fred gives the word. Generated by Claude Code |
Marcus Vorwaller's reactions work for macOS 27.2: a tapback on any message, not only the newest, through the Tapback Picker that "Tapback Details..." opens on that bubble, and an exact custom emoji (type 2006/3006, confirmed against associated_message_emoji in chat.db) through public native AX APIs and one frame-stable, hit-tested click on the glyph. The searchable ReactionPicker.qml is the UI; TapbackActions.mjs is regenerated from tapback-actions.ts. Conflicts resolved here: .github/workflows/ci.yml keeps both new steps (#163's audio suites and #159's reaction-picker suite); the "kind": "emoji" tapback line in bridge/mac/imsg was already on main from #162, so the duplicate hunk is dropped. Proven on the real macOS 27.2 gateway, self-thread only, with Fred's word: classic Heart on a 10 Oct message, custom emoji reaction (type 2006, exact emoji confirmed, kind "emoji" on the read path), a second reaction on an already-reacted bubble, and removal back to none. The first custom-emoji try refused with "moved" while the Mac was in use and pressed nothing. Checked on 5fc0454 merged onto ef9a1ab: bun test 877 pass, 7 Qt/Python suites, 92 bridge tests, qmllint clean, TapbackActions.mjs rebuilds identical, gitleaks clean, door one-way (ci.yml, bridge/mac/imsg-react) shown to Fred. LR-T: blip, pr-159, tapbacks, macos-27, custom-emoji, ax, merge LR-D: blip, bridge, qml LR-K: picker-route-any-message, exact-emoji-click-glyph, reacted-label-pattern LR-R: 33aab7b, ef9a1ab LR-L: law-4, law-10, law-11 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WHAT: the same-turn bookkeeping for the #159 merge (6a4fbce, 56bc294). - CHANGELOG.md: a proper Unreleased entry; the one-line note Marcus's rebase left above the "## Unreleased" heading is removed (it was orphaned there). - CHANGE.log: #159 entry with the live 27.2 proof and what Larry added. - CONTRIBUTORS-X.md: Marcus 5 merged (#158 #161 #162 #163 #159), #160 under review, X handle still none found (rechecked 2026-11-11, asked Fred). - WEEKLY-NOTES.md: W46 Wed 11 Nov, #159 bullet and the two Blip-side findings. NOT staged on purpose: bridge/mac/findmy_city.py and test_findmy_city.py are someone else's uncommitted work in this tree. LR-T: blip, pr-159, changelog, contributors, weekly-notes LR-D: blip, docs LR-K: pr-run-bookkeeping LR-R: 6a4fbce, 56bc294 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Hi Marcus, one question from Fred, who runs the Blip updates. Each week he posts an update on X that names everyone whose work landed. Four of your pull requests are in (#158, #161, #162, #163) and more are on the way, and he wants to credit you properly. Do you have an X handle you would like him to tag? If you would rather not be tagged, or would like your name or GitHub login written a particular way, say so here and that is what we will do. No handle is on your GitHub profile or on marcus.pictures, so without an answer you appear as "Marcus Vorwaller (github.com/marcus)". Thanks again for the quality of the work. Generated by Claude Code |
|
haha tell Fred I say thanks, totally unnecessary but appreciated. he can tag my GitHub handle and if he wants, point to haplab.com. |
…GitHub handle and optionally link haplab.com WHAT: CONTRIBUTORS-X.md roster row, WEEKLY-NOTES.md "handles Fred still needs to answer" entry, and the PEOPLE list at the top of CHANGE.log now record Marcus's own answer: no X account to tag; write "Marcus Vorwaller (github.com/marcus)" and, if wanted, point to haplab.com. WHY: Fred asked 2026-11-11 for him to be asked about credit on the Blip update posts. Asked on #163; he replied 2026-11-12 03:12Z ("he can tag my GitHub handle and if he wants, point to haplab.com"). Never guess an X handle for him. NOTE: older CHANGE.log entries that say "X: none found, asked Fred" are history and stay as written. LR-T: blip, contributors, marcus, credit, roster LR-D: blip, docs LR-K: marcus-no-x-credit-by-github-handle Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
|
Thanks Marcus, noted: Fred will credit you as Marcus Vorwaller (github.com/marcus) and can point to haplab.com. It is in the roster now, so it sticks for every update post. And he is glad to say it back: thanks for the work. Generated by Claude Code |
Audio attachments gain inline play/pause, a measured waveform, remaining time, seeking and keyboard controls. Exactly one plays. The view owns playback across message-model rebuilds; leaving the conversation or closing it cancels playback and delayed play intent. Decoding starts on a play click.
A recognized, explicitly selected demuxer feeds bounded FFmpeg decoding. Qt receives only a private, generated 24 kHz mono PCM WAV, never the received container. The content-hash WAV cache also supplies the waveform and counts toward cache eviction. Inline normalization is limited to ten minutes. QtMultimedia loads optionally; unavailable normalization/tools retain explicit-demuxer external mpv playback or Save. Original attachment files remain available for Save.
Based on current upstream main, including #158 and #161, and preserves its controls, theme and manifest. Validation: 829 Bun tests, 323 synthetic Mac Python tests, 7 muted real-WAV/Qt playback checks (including delegate rebuild), and 13 play-intent/session checks pass. Rendered media controls inspected; GitHub CI passes. No real conversations opened or live messages sent. Live-bar resource measurements remain unverified. Limits are in
docs/AUDIO.md.