Skip to content

Show Delivered under the newest sent message until read - #158

Merged
nixfred merged 1 commit into
nixfred:mainfrom
marcus:upstream-delivered
Nov 10, 2026
Merged

nixfred merged 1 commit into
nixfred:mainfrom
marcus:upstream-delivered

Conversation

@marcus

@marcus marcus commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

When a newly sent iMessage or RCS reaches the recipient, Blip now shows Delivered beneath it until the existing Read receipt arrives. Only the newest sent message owns a receipt; failed, retracted and scheduled rows do not claim delivery. Carrier SMS stays unchanged. Self-thread echo folding preserves delivery and read metadata.

First standalone split from #156, based on current main (3795d64). Keeps the existing theme, receipt timestamp formatting and manifest version. No restyle or configuration changes.

Validation: bun test (809 pass), python3 bridge/mac/test_read_sync.py (19 pass). Synthetic fixtures cover service gating, Read replacing Delivered, older receipts disappearing and self echoes in either order. Details in docs/delivery.md. No live messages sent.

Expose device acknowledgements for iMessage and RCS, preserve them when folding self echoes, and hide older receipts when a newer send arrives. Keep upstream timestamp formatting and theme. No send or read-mark behavior changes.
@marcus
marcus requested a review from nixfred as a code owner November 10, 2026 04:07
@nixfred
nixfred merged commit ea64c98 into nixfred:main Nov 10, 2026
1 check passed
nixfred added a commit that referenced this pull request Nov 10, 2026
…ll 4x faster (CHANGELOG, CHANGE.log, roster, weekly notes)

WHAT: CHANGELOG entries for #158 (Delivered until Read) and #161 (composer emoji picker) with the real end-to-end numbers for the poll speed-up (shallow 0.77 s to 0.2 s, deep 2.1 s to 1.0 s on gus); CHANGE.log entries for 401b99d, #158 and #161; Marcus Vorwaller added to the no-X table in CONTRIBUTORS-X.md (nothing on his GitHub profile or social accounts, his site marcus.pictures lists none, checked 10 Nov); WEEKLY-NOTES W46 section for 10 Nov with Marcus's own words about the rebases and the reasons #159 #160 #162 #163 were sent back.
WHY: the PR-run checklist records every merge the day it lands, with the contributor's real name and a verified X handle or a visible "none found" plus asking Fred the same day.
CONTEXT: independent review of #159 #160 #162 #163 (read-only, nothing sent to the Mac) found: #162 ffmpeg guessed the format from sender bytes (reproduced: a two-line ffconcat file delivered as a video rendered a different cached picture), #163 Qt plays bytes the safety check never saw and playback stops on any list rebuild, #160 three failure paths after Return report "nothing sent" and the recipient is never checked before Return (both confirmed against the code), #159 the shipped macOS 27 path has no test. Comments with the specifics are on each PR. Deployed 10 Nov to the gateway Mac (read_state.py and imsg, backups in ~/.blip/backups-20261110), gus and vic, all healthy, no log errors.
TAGS: docs, changelog, change-log, weekly-notes, roster, marcus, pr-run, review

LR-T: pr-run, contributor-pr, bookkeeping
LR-D: blip, docs
LR-K: pr-158-161-merged, pr-159-160-162-163-sent-back, marcus-no-x
LR-R: 401b99d, ea64c98, 0d302b1

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
@nixfred

nixfred commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Merged (main ea64c98), and thank you, Marcus. This is exactly the first split I asked for: small, on current main, with tests that say what the rule is. I like that the receipt now belongs to the newest sent message only, that failed, withdrawn and scheduled rows never claim "Delivered", and that the self-thread echo keeps its receipt in either order, including the empty-text case.

What I checked: an independent review found nothing to change, and all of the suite passes with your commit on top of main. The imsg change (three lines, is_delivered) is on the gateway Mac, on gus and on vic now, so "Delivered" should appear under your next message on any of them.

You are credited in the changelog and the weekly notes. I could not find an X account for you (nothing on your GitHub profile or social accounts, and marcus.pictures lists none), so if you have one and want it tagged in the thank-you post, tell me the handle.

The other four are commented with specifics. Thank you for the quick, careful split.


Generated by Claude Code

nixfred added a commit that referenced this pull request Nov 10, 2026
… (CHANGELOG, CHANGE.log, roster, weekly notes, CLAUDE.md)

WHAT: CHANGELOG and CHANGE.log entries for #162 (native stickers) and the reaction-scan speed-up (9b4f8d9) with the real numbers; CONTRIBUTORS-X.md moves Marcus Vorwaller to 3 merged (#158, #161, #162), still no X handle found and asked Fred; WEEKLY-NOTES W46 gets the #162 and speed-up bullets plus the note that #159, #160 and #163 got a second independent review of their rebased heads; CLAUDE.md's measured-latency paragraph gains the lesson from the reaction scan (the 90-day margin is real data: 3 of 28,305 reactions are stamped before their target, the worst by 0.83 days; an ORDER BY in SQL brings the full scan back; the date index reorders reactions unless sorted by ROWID; do not probe the guid index by shape because _strip_assoc is lenient on purpose).
WHY: the PR-run checklist records every merge the day it lands, and the next agent that "optimises" enrich() must find the traps written down instead of rediscovering them.
CONTEXT: Fred approved the #162 merge and the speed-up from the literal diffs on 10 Nov. Merge commit aee3394, speed-up 9b4f8d9.
TAGS: docs, changelog, change-log, weekly-notes, roster, claude-md, pr-run, stickers, latency

LR-T: pr-run, bookkeeping, latency
LR-D: blip, docs
LR-K: pr-162-merged, tapback-window-bound, marcus-no-x
LR-R: aee3394, 9b4f8d9

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BXN1v67b9f9VHGe3FhaQuD
nixfred added a commit that referenced this pull request Nov 11, 2026
WHAT: the same-turn bookkeeping for the #159 merge (6a4fbce, 56bc294).
  - CHANGELOG.md: a proper Unreleased entry; the one-line note Marcus's rebase
    left above the "## Unreleased" heading is removed (it was orphaned there).
  - CHANGE.log: #159 entry with the live 27.2 proof and what Larry added.
  - CONTRIBUTORS-X.md: Marcus 5 merged (#158 #161 #162 #163 #159), #160 under
    review, X handle still none found (rechecked 2026-11-11, asked Fred).
  - WEEKLY-NOTES.md: W46 Wed 11 Nov, #159 bullet and the two Blip-side findings.
NOT staged on purpose: bridge/mac/findmy_city.py and test_findmy_city.py are
  someone else's uncommitted work in this tree.

LR-T: blip, pr-159, changelog, contributors, weekly-notes
LR-D: blip, docs
LR-K: pr-run-bookkeeping
LR-R: 6a4fbce, 56bc294

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants