[wasud]

Decisions to review

• D2, data: OpenUpgrade 17 turns private partners into contacts and overwrites their address, phone, email, VAT, job position, website and notes with ***** (and clears country/state); the originals survive only in its ou_res_partner_private table. migrations/17.0.1.0.0/post-migration.py restores every masked column of the patient/encounter "other addresses" (street, street2, city, zip, state_id, country_id, phone, mobile, email, vat, function, website, comment) from that copy and sets them to type='other'. Checked by hand on a real OpenUpgrade 16→17 run (the patient's address comes back complete, unrelated private partners stay masked), plus a seeded check in a rolled-back transaction for vat/function/website/comment, since that run had no data in them. The migration snapshot ([16.0][ADD] tools: migration data snapshot script #143) does not hash other_address_id fields, so it would not catch this.
• D2, UI: a compact address form ni_patient.res_partner_view_form_address replaces base.res_partner_view_form_private (deprecated in 17, removed in 19).
• D7, extension seam: the JS files are renamed *.esm.js to match the OCA eslint config, so downstream imports change to @ni_patient/views/list_view.esm.

What changed

• ni_patient history replayed, then [IMP] pre-commit and [MIG] ni_patient: Migration to 17.0.
• D1:
  • ni.patient._rec_name = "name", so patients display by name, not HN.
  • _compute_display_name with depends_context on patient, encounter and location; _name_get() kept as the extension seam for ni_observation.
  • _rec_names_search on patient and encounter; res.partner._name_search uses the new signature.
• D2: type='other' domains and form context, compact address form, post-migration.
• D7:
  • getStaticActionMenuItems() replaces getActionMenuItems().
  • @odoo/owl import and _t import.
• Encounter lock: field states= moved into the form as readonly="state ..." (25 fields); ni.workflow intent/priority lose states= (documented for downstream forms).
• Other 17 changes:
  • Discharge wizard: the onchange no longer returns a domain; uses a computed discharge_disposition_domain instead.
  • Calendar quick_create.
  • file_path; from odoo import Command.
  • Field domains no longer hold lambdas.
  • No write() inside an onchange.
  • Named translation placeholders and lazy logging (pylint).
• New tests:
  • test_ni_patient_display_name.py (D1)
  • test_ni_patient_address.py (D2)
  • ni_coding/tests/test_ni_coding_default_views.py ([MIG 19.0][P1-1] Foundation: ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias #136 acceptance; lives in ni_coding, the module it tests)
• th.po regenerated; translations dropped by the export restored from 16.0.

Why

Part of #137 (P1-2, epic #131).

Migration notes

• Effort: L.
• What the migrator did: attrs in 16 view files.
• Manual work:
  • All states= (fields, groups).
  • name_get/_name_search, private partners, JS.
  • The discharge onchange domain.
  • Calendar attribute.
  • Lint backlog (~25 items the template's pylint/ruff now flag).
• Surprises:
  • OpenUpgrade masks private addresses (D2).
  • Field domains holding lambdas never worked.
  • The portal patient detail page fails with only ni_patient installed because ni_patient_portal_templates.xml reads encounter.performer_id (a ni_practitioner field). This already happens on 16.0, so it is not fixed here; it belongs in P0-4 ([MIG 19.0][P0-4][FIX] Pre-existing bugs found during the 19.0 migration scan (16.0) #135).

How tested

• Unit/integration tests: 32 tests pass on 17 (24 existing + 8 new).
• Manual check (browser, Odoo 17 with demo data):
  • patient list with search panel;
  • Archive from the list and from the form opens the archive wizard, which shows the patient name;
  • "Other address" create opens the compact form and saves type='other';
  • encounter kanban, calendar and form, with in-progress fields locked as expected;
  • discharge wizard domain changes with the status (shell Form);
  • portal /my/home and /my/patients.
  • No JS console errors.
• OpenUpgrade 16→17 on a 16 DB without demo: the D2 post-migration restores the patient address.
• pre-commit clean on ni_patient.

Documentation

• Module README.md updated (display names, addresses, encounter locking, JS seam, tests)

Notes for reviewer

• Fix (2026-10-14): odoo-module-migrate 17 rewrote Thai text in XML (comments, string, placeholder) as &#NNNN; entities, and prettier then split one of them with spaces. The Thai text is back as UTF-8.
• Fix (2026-10-14): from 17.0, invisible="1" on a list field only hides the cells, so the column header still shows. Hidden list fields now use column_invisible="1". Found in the browser check of ni_observation ([MIG 19.0][P1-4] ni_observation #139).
• Stacked on [17.0][MIG] ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias: Migration to 17.0 #147 (P1-1 17.0); merge [17.0][MIG] ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias: Migration to 17.0 #147 first.

[piruin]

Review

Fix before merge: the private-address restore misses some masked columns.

OpenUpgrade 17 (base/17.0.1.3/pre-migration.py, _handle_partner_private_type) overwrites these columns with *****: street, street2, city, zip, vat, function, phone, mobile, email, website, comment. It also clears country_id and state_id.

migrations/17.0.1.0.0/post-migration.py doesn't restore vat, function, website or comment, so those stay ***** on the restored patient addresses. comment (the address notes) is the one most likely to hold real data. Please add the four columns to the SET clause.

The migration snapshot (#143) doesn't hash other_address_id fields, so it would not catch this. The "verified" claim rests on a manual check only.

Minor

• tests/test_ni_coding_default_views.py lives in ni_patient but tests ni_coding behaviour.

Checked, OK

• Each of the 25 field-level states= locks from 16.0 that is still on the encounter form now has an equivalent readonly= there. The other three (name, location_history_ids, participant_ids) aren't on any form.
• The private page name on the patient form is kept, so the ni_related_person xpath still matches.
• _compute_display_name has the right depends_context keys, _rec_names_search is set, and res.partner._name_search uses the 17 signature.
• The discharge wizard uses a computed domain field instead of returning a domain from the onchange.
• CI is green, and the commit series ends with [IMP] pre-commit auto fixes + [MIG].

Note: #154 and #155 replay this branch, so any code change here needs to be replayed forward (except the 17.0 migration script, which exists only on 17.0).

[wasud]

Thanks. Fixed in the [MIG] commit (now 44b8bc17):

• post-migration.py now also restores vat, function, website and comment, so it covers every column OpenUpgrade masks, plus state_id/country_id.
• Verified on mig17_d2 (a real OpenUpgrade 16→17 run) inside a rolled-back transaction, because that run has no data in these four columns: I seeded ***** on the other-address partners and the real values in ou_res_partner_private, then ran the script, and all four values came back. The PR body now says the check is manual plus this seeded one, and that the [16.0][ADD] tools: migration data snapshot script #143 snapshot does not cover other_address_id.
• Minor: the default-views test moved to ni_coding/tests/ and now tests the abstract ni.coding directly, with no ni_patient models. The same move is replayed in [18.0][MIG] ni_patient: Migration to 18.0 #154 and [19.0][MIG] ni_patient: Migration to 19.0 #155.

The 17.0 observation and questionnaire stacks were rebased on top; their content is unchanged.