[wasud]

What changed

• ni.encounter.check_origin_date now raises ValidationError. Before, it raised the translated string itself.
• The transfer date (origin_date, a Date) is compared with the encounter start date in the user's timezone. Before, it was compared with period_start, a UTC Datetime. The check is skipped when the encounter has no start.
• New tests/test_ni_encounter_origin_date.py.
• ni_patient 16.0.0.4.0 → 16.0.0.4.1.

Why

Both branches of the constraint fail with a TypeError instead of a validation error:

• raise _("...") raises a plain string ("exceptions must derive from BaseException").
• Date > Datetime raises on every encounter that has both a transfer date and a start, and on encounters with a transfer date but no start.

Reported by piruin in the review of the 19.0 migration (#155), who asked for the fix on 16.0 and a forward-port. Part of P0-4 (#135), epic #131.

How tested

• -i ni_patient --test-tags /ni_patient on a fresh 16.0 DB: 29 tests, 0 failed.
• pre-commit clean on the changed files.

Notes for reviewer

• No data change, and constraints only run on write, so existing encounters are not re-checked.
• Forward-ports for 17.0/18.0/19.0 are prepared locally. They will follow with oca-port once this is merged and the migration PRs ([17.0][MIG] ni_patient: Migration to 17.0 #153–[19.0][MIG] ni_patient: Migration to 19.0 #155) are in.

[piruin]

Closing as a duplicate of #166. The check_origin_date fix, tests/test_ni_encounter_origin_date.py and the ni_patient 16.0.0.4.1 bump here are identical to row 1 of #166's ni_patient commit.

If both were merged:

• ni_patient/tests/__init__.py would conflict;
• the same fix would be in 16.0 twice, in different commits, which doubles the oca-port work for 17/18/19;
• ni_patient would stay at 16.0.0.4.1 after the second merge, even though that merge adds more changes.

The fix is still wanted: it lands with #166, and its forward-ports follow #166's commits.