[wasud]

Decisions to review

• D7, list widget: ob_section_and_note_one2many is re-ported from core account 17 section_and_note_fields_backend (registry descriptors, @odoo/owl, useEffect on the edited record), not patched from the 16 port. The Nirun parts are kept: category sections and the value columns.
• D8, badge: ni_observation installs and validates on a fresh DB without web_notebook_advance; only the counter on the Vital Signs/Laboratory tabs is missing. Kept as a soft dependency and noted in the README.
• Behaviour fix, wizard: the encounter domain on ni.observation.wizard.encounter_id used parent_id, which does not exist on ni.encounter, through a Field object, so it never filtered. It now filters on patient_id.

What changed

• ni_observation history replayed, then [IMP] pre-commit and [MIG] ni_observation: Migration to 17.0.
• Display names:
  • name_get → _compute_display_name on reference range and sheet (depends_context("show_occurrence")).
  • The patient _name_get() extension now has @api.depends("blood_group").
• Counts: read_group → _read_group(..., ["__count"]) with the tuple results (patient, encounter, type).
• Wizard:
  • states="1"/"2" → invisible expressions.
  • String domains.
  • company_id added to the line list, which 17 requires for the check_company domain on encounter_id.
• Encounter: the non-stored compute assigns its fields instead of calling write().
• Views:
  • attrs → expressions (migrator).
  • Hidden list fields use column_invisible.
  • always_reload dropped.
  • A hidden company_id sits next to the group-restricted one.
• The "New Observation" context no longer sends [False] as default_category_ids when no category is selected. 17 tried to create a nameless category.
• Other:
  • fields.Datetime.now.
  • <odoo noupdate> without <data>.
  • Asset paths without the leading /.
  • Named translation placeholders, lint backlog.
• th.po regenerated, 16.0 translations merged back, UI terms filled (lab test names and units stay in English, as in Thai clinical use).

Why

Part of #139 (P1-4, epic #131).

Migration notes

• Effort: L.
• What the migrator did: attrs in 11 view files.
• Manual work:
  • states= in the wizard;
  • name_get and read_group;
  • the D7 widget re-port;
  • Field-object domains;
  • list column_invisible;
  • the lint backlog (~20 items).
• Surprises:
  • From 17, invisible="1" in a list hides only the cells; the column header still shows. The same issue was in ni_coding, ni_patient and survey_grading, fixed in [17.0][MIG] ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias: Migration to 17.0 #147–[19.0][MIG] ni_patient: Migration to 19.0 #155.
  • 17 validates check_company domains in embedded lists, so company_id must be in the view.
  • default_x_ids: [False] creates an empty record in 17.

How tested

• Unit/integration tests: 25 tests pass on 17 (fresh DB with ni_observation), plus 57 with ni_coding,ni_patient,ni_observation.
• Manual check (browser, Odoo 17 with demo data):
  • Observation sheet:
    • sections per category and hidden technical columns;
    • entering systolic/diastolic: interpretation colours update live;
    • save computes BP "150 / 95".
  • Encounter: Vital Signs tab (latest values, BMI), Observation tab with category filter.
  • Wizard: New → category → line list → value → Save; the reading lands on the encounter with the right interpretation.
  • Observation list, date filter, pivot; patient Observation tab.
  • Display names: sheet with show_occurrence, reference range Type [low-high].
  • No JS console errors.
• pre-commit clean on ni_observation (two eslint warnings that come from the core account code).

Documentation

• Module README.md updated (17.0, display names, list widget, D8 soft dependency)

Notes for reviewer

• Added after review started (P1-6 pilot, [MIG 19.0][P1-6] Data migration pilot: OpenUpgrade 16→17→18→19 on Phase 1 modules #141): [FIX] ni_observation: pick the latest observation deterministically. The latest-observation views (ni.patient.observation, ni.encounter.observation) used DISTINCT ON ... ORDER BY occurrence DESC with no tie-breaker. Two observations of a type with the same occurrence made the patient and encounter forms fail ("records ... cannot be found") on the pilot DB. Now occurrence DESC, id DESC, with tests/test_latest_observation.py (fails without the fix). 16.0 has the same views.

• Fix (2026-10-14): odoo-module-migrate 17 rewrote Thai text in XML (comments, string, placeholder) as &#NNNN; entities, and prettier then split one of them with spaces. The Thai text is back as UTF-8.

• Stacked on [17.0][MIG] ni_patient: Migration to 17.0 #153 (P1-2 17.0), which is stacked on [17.0][MIG] ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias: Migration to 17.0 #147. Merge those first.

• Not changed yet: the SQL views in report/ still use SELECT DISTINCT ON … *. They work on 17; the explicit column list and SQL() come with 19.0.

[piruin]

Review

No blockers.

Checked, OK

• read_group → _read_group(..., ["__count"]) reads the tuple results correctly (patient, encounter, type).
• The _compute_display_name override in ni_patient with @api.depends("blood_group") works: Odoo merges the depends of every override, so ni_patient's depends_context keys still apply.
• The wizard domain fix (parent_id → patient_id, string domains) is correct.
• The encounter compute now assigns values instead of calling write().
• The list widget is re-ported with field descriptors, @odoo/owl imports, isNew and useEffect on the edited record.
• The latest-observation [FIX] was done the epic's way: fixed on 16.0 in #163 (merged), then carried forward.
• CI is green, and the series ends with [IMP] pre-commit auto fixes + [MIG].

Minor

• report/ still uses SELECT DISTINCT ON … *, as noted in the PR body.