Add support for waitUntilAvailable#3474
Open
jesup wants to merge 1 commit intousers/jesup/anticipated_streamsfrom
Open
Add support for waitUntilAvailable#3474jesup wants to merge 1 commit intousers/jesup/anticipated_streamsfrom
jesup wants to merge 1 commit intousers/jesup/anticipated_streamsfrom
Conversation
jesup
requested review from
KershawChang,
larseggert,
martinthomson and
mxinden
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Http3ClientEvent::StreamCreatable event to neqo-http3, which surfaces the transport-layer SendStreamCreatable event with stream type information. This supports the waitUntilAvailable WebTransport API by signaling when stream quota becomes available.
Changes:
- Added
StreamCreatable { stream_type }variant toHttp3ClientEventand the corresponding event emission method - Wired
ConnectionEvent::SendStreamCreatableto emit the new event alongside the existingRequestsCreatable - Added two integration tests verifying the event fires on connect and on MAX_STREAMS replenishment
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| neqo-http3/src/client_events.rs | New StreamCreatable event variant and stream_creatable() emission method |
| neqo-http3/src/connection_client.rs | Emit StreamCreatable on SendStreamCreatable transport event; updated doc comment |
| neqo-http3/tests/webtransport.rs | Two new tests for StreamCreatable during handshake and MAX_STREAMS |
| neqo-http3/tests/classic_connect.rs | Allow StreamCreatable in the expected-events filter |
mxinden
reviewed
Apr 1, 2026
jesup
force-pushed
the
users/jesup/anticipated_streams
branch
from
225f726 to
3dba9cd
Compare
jesup
force-pushed
the
users/jesup/waitUntilAvailable
branch
from
6ffa7e2 to
c4a9fe7
Compare
This was referenced May 1, 2026
Member
Author
|
This PR is part of a stack of 13 bookmarks:
Created with jj-stack |
Contributor
Failed Interop TestsNone ❓ All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as clientNone ❓ neqo-pr as serverNone ❓ Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as clientNone ❓ neqo-pr as serverNone ❓ |
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.