WebTransport sendGroup support (and improve sendOrder)#3467
Open
jesup wants to merge 5 commits intousers/jesup/sub_protocolfrom
Open
WebTransport sendGroup support (and improve sendOrder)#3467jesup wants to merge 5 commits intousers/jesup/sub_protocolfrom
jesup wants to merge 5 commits intousers/jesup/sub_protocolfrom
Conversation
jesup
requested review from
KershawChang,
larseggert,
martinthomson and
mxinden
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds WebTransport send group support to the QUIC transport and HTTP/3 layers, implementing the spec requirement that WebTransportSendGroups are treated as bandwidth-equals with per-group sendOrder namespacing. The changes introduce a SendGroupId type, per-group scheduling queues with round-robin fairness at the transport layer, and session-scoped send group registration/validation at the HTTP/3 layer.
Changes:
- New
SendGroupIdandSendGrouptypes inneqo-http3, with a global atomic counter for unique IDs and a sentinel value (0) reserved for ungrouped streams. - Transport-layer scheduling refactored from flat
sendordered/regularqueues to per-groupPerGroupQueueswith round-robin between groups and sendOrder-based priority within each group. - HTTP/3 APIs for creating, registering, and validating send groups on WebTransport sessions, including stream creation with send group assignment.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
neqo-http3/src/features/extended_connect/send_group.rs |
New file: SendGroupId newtype with atomic counter and SendGroup struct |
neqo-http3/src/features/extended_connect/mod.rs |
Adds pub mod send_group |
neqo-http3/src/features/extended_connect/webtransport_session.rs |
Session-level send group registration, validation, and storage |
neqo-http3/src/features/extended_connect/webtransport_streams.rs |
WebTransportSendStream gains send_group field and trait impls |
neqo-http3/src/features/extended_connect/session.rs |
Protocol trait extended with send group methods; forwarding impls |
neqo-http3/src/lib.rs |
Re-exports SendGroupId; adds Stream/SendStream trait methods |
neqo-http3/src/connection.rs |
Http3Connection gains send group set/clear, register/validate, and stream creation with send group |
neqo-http3/src/connection_client.rs |
Public API: webtransport_set_sendgroup, webtransport_register_send_group, webtransport_create_stream_with_send_group |
neqo-transport/src/send_stream.rs |
PerGroupQueues, refactored SendStreams with per_group IndexMap and round-robin scheduling |
neqo-transport/src/streams.rs |
New SendGroupId type alias and set_sendgroup forwarding |
neqo-transport/src/connection/mod.rs |
Public stream_sendgroup API on Connection |
neqo-http3/src/features/extended_connect/tests/webtransport/sessions.rs |
Comprehensive tests for send group creation, validation, cross-session rejection, fair bandwidth allocation, and sendOrder within groups |
jesup
changed the title
jesup
force-pushed
the
users/jesup/sub_protocol
branch
from
c2bb439 to
58be5ff
Compare
Member
|
Given the large merge conflicts, can you do another rebase before review? Can also review now, though I am afraid comments might get lost. |
Collaborator
|
It needs a rebase so CI runs |
jesup
force-pushed
the
users/jesup/sub_protocol
branch
2 times, most recently
from
c140eef to
723a367
Compare
jesup
force-pushed
the
users/jesup/sendGroup
branch
from
9c15fa5 to
9a89365
Compare
This was referenced Apr 29, 2026
Member
Author
|
This PR is part of a stack of 13 bookmarks:
Created with jj-stack |
jesup
force-pushed
the
users/jesup/sendGroup
branch
from
9a89365 to
d564de8
Compare
Fixes existing bug where low priority streams could be starved forever: After the highest-sendOrder stream within a group exhausted its queued data (but remained open), PerGroupQueues::next_stream_id() kept returning it, permanently starving lower-sendOrder streams in the same group.
jesup
force-pushed
the
users/jesup/sendGroup
branch
from
d564de8 to
f5b9bdc
Compare
Contributor
Failed Interop TestsNone ❓ All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as clientNone ❓ neqo-pr as serverNone ❓ Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as clientNone ❓ neqo-pr as serverNone ❓ |
This was referenced Apr 30, 2026
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.