Track bytesSentOverhead separately per WebTransport spec#3471
Open
jesup wants to merge 1 commit intousers/jesup/sendgroup_sendorder_trackingfrom
Open
Track bytesSentOverhead separately per WebTransport spec#3471jesup wants to merge 1 commit intousers/jesup/sendgroup_sendorder_trackingfrom
jesup wants to merge 1 commit intousers/jesup/sendgroup_sendorder_trackingfrom
Conversation
jesup
requested review from
KershawChang,
larseggert,
martinthomson and
mxinden
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WebTransport session statistics to track bytesSentOverhead separately, aligning the implementation with the WebTransport stats model by separating payload bytes from framing overhead.
Changes:
- Add
bytes_sent_overheadtoWebTransportSessionStats. - Record overhead bytes emitted by the WebTransport datagram queue and expose them via session stats.
- Wire the new overhead accounting through the
Protocolabstraction for WebTransport sessions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
neqo-http3/src/features/extended_connect/webtransport_session.rs |
Adds a session stats counter and protocol hook to record sent datagram overhead bytes. |
neqo-http3/src/features/extended_connect/stats.rs |
Extends the public WebTransport session stats struct with bytes_sent_overhead. |
neqo-http3/src/features/extended_connect/session.rs |
Plumbs overhead bytes returned from datagram queue processing into protocol/session stats. |
jesup
force-pushed
the
users/jesup/sendgroup_sendorder_tracking
branch
from
d6cb526 to
48ece96
Compare
jesup
force-pushed
the
users/jesup/sendgroup_sendorder_tracking
branch
from
48ece96 to
17fea3f
Compare
jesup
force-pushed
the
users/jesup/stats_overhead
branch
from
ae31280 to
cdc8278
Compare
This was referenced May 1, 2026
Member
Author
|
This PR is part of a stack of 13 bookmarks:
Created with jj-stack |
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.