Conversation
- northeurope: GMT Standard Time → W. Europe Standard Time - uksouth: GMT Standard Time → Greenwich Mean Time - ukwest: GMT Standard Time → Greenwich Mean Time Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This pull request aims to fix incorrect timezone mappings for European regions in the FinOps hubs managed exports trigger scheduling, addressing issue #1512. The changes modify the timezone values for three Azure regions: North Europe (Ireland), UK South, and UK West.
Changes:
- Changed
northeuropetimezone fromGMT Standard TimetoW. Europe Standard Time - Changed
uksouthandukwesttimezones fromGMT Standard TimetoGreenwich Mean Time
| northeurope: 'W. Europe Standard Time' | ||
| norwayeast: 'W. Europe Standard Time' | ||
| norwaywest: 'W. Europe Standard Time' | ||
| southcentralus: 'Central Standard Time' | ||
| southindia: 'India Standard Time' | ||
| southeastasia: 'Singapore Standard Time' | ||
| switzerlandnorth: 'W. Europe Standard Time' | ||
| switzerlandwest: 'W. Europe Standard Time' | ||
| uksouth: 'GMT Standard Time' | ||
| ukwest: 'GMT Standard Time' | ||
| uksouth: 'Greenwich Mean Time' | ||
| ukwest: 'Greenwich Mean Time' |
There was a problem hiding this comment.
This change requires a changelog entry in docs-mslearn/toolkit/changelog.md. According to the repository's coding guidelines, every change must have a changelog entry with no exceptions for bug fixes, features, or improvements.
Since package.json shows version 13.0.0, this fix should be documented under a new "## v14" section (or "v13 Update 2" if this is a hotfix for v13) in the changelog under "### [FinOps hubs] v14" > "- Fixed" with an entry like:
- Fixed incorrect timezone mappings for European regions in managed exports (northeurope, uksouth, ukwest) to ensure Data Factory triggers start correctly ([[Hubs/AOE] Deal with duplicate recommendations ingestion #1512]).
This is particularly important because incorrect timezone mappings can cause Data Factory triggers to fail to start, which is a user-facing issue.
| koreasouth: 'Korea Standard Time' | ||
| northcentralus: 'Central Standard Time' | ||
| northeurope: 'GMT Standard Time' | ||
| northeurope: 'W. Europe Standard Time' |
There was a problem hiding this comment.
The timezone change for northeurope from "GMT Standard Time" to "W. Europe Standard Time" may be incorrect. The North Europe Azure region is physically located in Ireland (Dublin), which observes the same timezone as the UK: UTC+0 in winter and UTC+1 in summer (British Summer Time/Irish Summer Time).
"W. Europe Standard Time" is Central European Time (UTC+1/+2), which is used by continental European countries like Netherlands (where westeurope is located), France, Germany, Norway, and Switzerland - all of which correctly use "W. Europe Standard Time" in this file.
Ireland and the UK should use the same timezone setting. If the original "GMT Standard Time" was causing issues (as mentioned in issue #1512), then both northeurope and the UK regions (uksouth, ukwest) should use the same corrected timezone value. Please verify the correct timezone for the Ireland/UK regions that resolves the issue mentioned in #1512.
| uksouth: 'Greenwich Mean Time' | ||
| ukwest: 'Greenwich Mean Time' |
There was a problem hiding this comment.
"Greenwich Mean Time" does not appear to be a standard Windows timezone ID. The standard Windows timezone ID for the UK/Ireland/Portugal timezone (UTC+0 with DST to UTC+1) is "GMT Standard Time".
Azure Data Factory schedule triggers use Windows timezone IDs. According to Microsoft documentation, valid timezone strings should match Windows timezone IDs. Please verify that "Greenwich Mean Time" is actually accepted by Azure Data Factory, or if it should be "GMT Standard Time" instead.
If "GMT Standard Time" was the issue mentioned in #1512, please clarify what the actual problem was and what the correct timezone string should be for UK regions.
| uksouth: 'Greenwich Mean Time' | |
| ukwest: 'Greenwich Mean Time' | |
| uksouth: 'GMT Standard Time' | |
| ukwest: 'GMT Standard Time' |
|
@RolandKrummenacher I've opened a new pull request, #1999, to work on those changes. Once the pull request is ready, I'll request review from you. |
🛠️ Description
Fixed incorrect timezone mappings for European regions in the FinOps hubs managed exports trigger scheduling:
northeurope: Changed fromGMT Standard TimetoW. Europe Standard Timeuksouth: Changed fromGMT Standard TimetoGreenwich Mean Timeukwest: Changed fromGMT Standard TimetoGreenwich Mean TimeFixes #1512
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?