Skip to content

Fix timezone mappings for European regions#1998

Open
flanakin wants to merge 1 commit intodevfrom
flanakin/fix-timezone-europe
Open

Fix timezone mappings for European regions#1998
flanakin wants to merge 1 commit intodevfrom
flanakin/fix-timezone-europe

Conversation

@flanakin
Copy link
Collaborator

🛠️ Description

Fixed incorrect timezone mappings for European regions in the FinOps hubs managed exports trigger scheduling:

  • northeurope: Changed from GMT Standard Time to W. Europe Standard Time
  • uksouth: Changed from GMT Standard Time to Greenwich Mean Time
  • ukwest: Changed from GMT Standard Time to Greenwich Mean Time

Fixes #1512

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Public docs in docs-mslearn (required for dev)
  • ✅ Internal dev docs in docs-wiki (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

- northeurope: GMT Standard Time → W. Europe Standard Time
- uksouth: GMT Standard Time → Greenwich Mean Time
- ukwest: GMT Standard Time → Greenwich Mean Time

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@flanakin flanakin requested a review from MSBrett as a code owner February 13, 2026 09:31
Copilot AI review requested due to automatic review settings February 13, 2026 09:31
@microsoft-github-policy-service microsoft-github-policy-service bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Feb 13, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Skill: Deployment Resource deployment automation via bicep or terraform label Feb 13, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Tool: FinOps hubs Data pipeline solution label Feb 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aims to fix incorrect timezone mappings for European regions in the FinOps hubs managed exports trigger scheduling, addressing issue #1512. The changes modify the timezone values for three Azure regions: North Europe (Ireland), UK South, and UK West.

Changes:

  • Changed northeurope timezone from GMT Standard Time to W. Europe Standard Time
  • Changed uksouth and ukwest timezones from GMT Standard Time to Greenwich Mean Time

Comment on lines +25 to +34
northeurope: 'W. Europe Standard Time'
norwayeast: 'W. Europe Standard Time'
norwaywest: 'W. Europe Standard Time'
southcentralus: 'Central Standard Time'
southindia: 'India Standard Time'
southeastasia: 'Singapore Standard Time'
switzerlandnorth: 'W. Europe Standard Time'
switzerlandwest: 'W. Europe Standard Time'
uksouth: 'GMT Standard Time'
ukwest: 'GMT Standard Time'
uksouth: 'Greenwich Mean Time'
ukwest: 'Greenwich Mean Time'
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change requires a changelog entry in docs-mslearn/toolkit/changelog.md. According to the repository's coding guidelines, every change must have a changelog entry with no exceptions for bug fixes, features, or improvements.

Since package.json shows version 13.0.0, this fix should be documented under a new "## v14" section (or "v13 Update 2" if this is a hotfix for v13) in the changelog under "### [FinOps hubs] v14" > "- Fixed" with an entry like:

This is particularly important because incorrect timezone mappings can cause Data Factory triggers to fail to start, which is a user-facing issue.

Copilot generated this review using guidance from repository custom instructions.
koreasouth: 'Korea Standard Time'
northcentralus: 'Central Standard Time'
northeurope: 'GMT Standard Time'
northeurope: 'W. Europe Standard Time'
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timezone change for northeurope from "GMT Standard Time" to "W. Europe Standard Time" may be incorrect. The North Europe Azure region is physically located in Ireland (Dublin), which observes the same timezone as the UK: UTC+0 in winter and UTC+1 in summer (British Summer Time/Irish Summer Time).

"W. Europe Standard Time" is Central European Time (UTC+1/+2), which is used by continental European countries like Netherlands (where westeurope is located), France, Germany, Norway, and Switzerland - all of which correctly use "W. Europe Standard Time" in this file.

Ireland and the UK should use the same timezone setting. If the original "GMT Standard Time" was causing issues (as mentioned in issue #1512), then both northeurope and the UK regions (uksouth, ukwest) should use the same corrected timezone value. Please verify the correct timezone for the Ireland/UK regions that resolves the issue mentioned in #1512.

Copilot uses AI. Check for mistakes.
Comment on lines +33 to +34
uksouth: 'Greenwich Mean Time'
ukwest: 'Greenwich Mean Time'
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Greenwich Mean Time" does not appear to be a standard Windows timezone ID. The standard Windows timezone ID for the UK/Ireland/Portugal timezone (UTC+0 with DST to UTC+1) is "GMT Standard Time".

Azure Data Factory schedule triggers use Windows timezone IDs. According to Microsoft documentation, valid timezone strings should match Windows timezone IDs. Please verify that "Greenwich Mean Time" is actually accepted by Azure Data Factory, or if it should be "GMT Standard Time" instead.

If "GMT Standard Time" was the issue mentioned in #1512, please clarify what the actual problem was and what the correct timezone string should be for UK regions.

Suggested change
uksouth: 'Greenwich Mean Time'
ukwest: 'Greenwich Mean Time'
uksouth: 'GMT Standard Time'
ukwest: 'GMT Standard Time'

Copilot uses AI. Check for mistakes.
@RolandKrummenacher
Copy link
Collaborator

@copilot Is this related to #1995 , too?

Copy link
Contributor

Copilot AI commented Feb 13, 2026

@RolandKrummenacher I've opened a new pull request, #1999, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants