Skip to content

Fix timezone mappings for European regions #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flanakin wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix timezone mappings for European regions #1998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/templates/finops-hub/modules/Microsoft.CostManagement/ManagedExports/timeZones.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ param timezoneobject object = {
koreacentral: 'Korea Standard Time'
koreasouth: 'Korea Standard Time'
northcentralus: 'Central Standard Time'
northeurope: 'GMT Standard Time'
northeurope: 'W. Europe Standard Time'
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timezone change for northeurope from "GMT Standard Time" to "W. Europe Standard Time" may be incorrect. The North Europe Azure region is physically located in Ireland (Dublin), which observes the same timezone as the UK: UTC+0 in winter and UTC+1 in summer (British Summer Time/Irish Summer Time).

"W. Europe Standard Time" is Central European Time (UTC+1/+2), which is used by continental European countries like Netherlands (where westeurope is located), France, Germany, Norway, and Switzerland - all of which correctly use "W. Europe Standard Time" in this file.

Ireland and the UK should use the same timezone setting. If the original "GMT Standard Time" was causing issues (as mentioned in issue #1512), then both northeurope and the UK regions (uksouth, ukwest) should use the same corrected timezone value. Please verify the correct timezone for the Ireland/UK regions that resolves the issue mentioned in #1512.

Copilot uses AI. Check for mistakes.
norwayeast: 'W. Europe Standard Time'
norwaywest: 'W. Europe Standard Time'
southcentralus: 'Central Standard Time'
southindia: 'India Standard Time'
southeastasia: 'Singapore Standard Time'
switzerlandnorth: 'W. Europe Standard Time'
switzerlandwest: 'W. Europe Standard Time'
uksouth: 'GMT Standard Time'
ukwest: 'GMT Standard Time'
uksouth: 'Greenwich Mean Time'
ukwest: 'Greenwich Mean Time'
Comment on lines +25 to +34
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change requires a changelog entry in docs-mslearn/toolkit/changelog.md. According to the repository's coding guidelines, every change must have a changelog entry with no exceptions for bug fixes, features, or improvements.

Since package.json shows version 13.0.0, this fix should be documented under a new "## v14" section (or "v13 Update 2" if this is a hotfix for v13) in the changelog under "### [FinOps hubs] v14" > "- Fixed" with an entry like:

This is particularly important because incorrect timezone mappings can cause Data Factory triggers to fail to start, which is a user-facing issue.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +33 to +34
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Greenwich Mean Time" does not appear to be a standard Windows timezone ID. The standard Windows timezone ID for the UK/Ireland/Portugal timezone (UTC+0 with DST to UTC+1) is "GMT Standard Time".

Azure Data Factory schedule triggers use Windows timezone IDs. According to Microsoft documentation, valid timezone strings should match Windows timezone IDs. Please verify that "Greenwich Mean Time" is actually accepted by Azure Data Factory, or if it should be "GMT Standard Time" instead.

If "GMT Standard Time" was the issue mentioned in #1512, please clarify what the actual problem was and what the correct timezone string should be for UK regions.

Suggested change
uksouth: 'Greenwich Mean Time'
ukwest: 'Greenwich Mean Time'
uksouth: 'GMT Standard Time'
ukwest: 'GMT Standard Time'

Copilot uses AI. Check for mistakes.
westcentralus: 'Central Standard Time'
westeurope: 'W. Europe Standard Time'
westindia: 'India Standard Time'
Expand Down