Open
Conversation
…g, and update Node.js to v20.
This was referenced Mar 8, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three independent CI failures that were blocking the integration test suite. No production behaviour changes — all fixes are either infra config or test-image-only patches.
Related issue
Part of tracking epic #99
Type of change
How to test
Checklist
Notes for reviewers
Three independent bugs, three minimal fixes:
1. Container always unhealthy
docker-compose.ymlhealthcheck usedcurlbut the runtime image only shipswget. Changed towget.2. Node.js crash —
Unexpected end of formfile.on('error')was registered inside the asyncmkdtempcallback insrc/controller/package.ts. If busboy emitted the error beforemkdtempresolved, no listener existed and Node.js threw an unhandled error event crashing the process. Fixed by attaching the error guard immediately at the top of the file handler, before any async work.3. HTTP 400 on every
metacall-deploy --devform-data.getLengthSync()computes the wrong byte count for archiver streams, setting an incorrectContent-Lengthheader. The server reads exactly that many bytes and treats the remainder as a malformed second request → 400. Fixed by patching@metacall/protocolin the Dockerfile test stage to force chunked transfer encoding. The patch only affects the test image and fails the build loudly if the upstream source changes.test/test.sh—BASE_URLnow reads from$FAAS_URLenv var (default:http://localhost:9000) so CI can redirect the runner without editing the script.Release notes
CI integration tests now pass end-to-end. No changes to production server behaviour.
Test
