feat: Introduce safeResolve and deployment name validation to preve…#123
Open
codxbrexx wants to merge 1 commit intometacall:masterfrom
Open
feat: Introduce safeResolve and deployment name validation to preve…#123codxbrexx wants to merge 1 commit intometacall:masterfrom
safeResolve and deployment name validation to preve…#123codxbrexx wants to merge 1 commit intometacall:masterfrom
Conversation
…nt path traversal, and fix a dependency issue in the Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
safeResolveutility and a deployment name allowlist to make sure recursive deletes can't escape the app directory. Also includes two CI fixes that were blocking local integration tests.Related issue
Part of tracking epic #99
Fixes #121
Type of change
How to test
fix/path-traversal-delete-guardsnpm cinpm test, all 20 tests should pass including the newsafeResolve()suiteDELETE /api/deploywithsuffix: "../etc", expect a400Checklist
Notes for reviewers
Three things changed in this PR:
Issue 8 (path traversal):
src/utils/safePath.ts—safeResolve(baseDir, child)resolves the target path and throws400if it escapesbaseDirdelete.ts— validatessuffixagainst^[a-zA-Z0-9._-]+$before any path work; usessafeResolveinstead of rawjoinrepository.ts—repositoryDeletehelper now usessafeResolveso the cleanup can't escapeappsDirectoryeven ifrepositoryNamedegradesRelease notes
Added path boundary validation to the delete endpoint and repository cleanup. A crafted deployment name can no longer cause
rmto delete files outside the app directory.Test