fix(test): patch metacall protocol to ensure chunked deployment#125
Open
codxbrexx wants to merge 1 commit intometacall:masterfrom
Open
fix(test): patch metacall protocol to ensure chunked deployment#125codxbrexx wants to merge 1 commit intometacall:masterfrom
codxbrexx wants to merge 1 commit intometacall:masterfrom
Conversation
8 tasks
|
Hi @codxbrexx , I was also trying to locally deploy the whole things but didnt worked out |
Contributor
Author
|
@prathamtomar99 Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR patches
@metacall/protocolinside the Docker test environment to prevent a400 Bad Requesterror when deploying packages viametacall-deploy --devduring FaaS integration tests.Issue screenshot
The patch invalidates the
getLengthSyncmethod on the form data object, forcingaxiosto fall back toTransfer-Encoding: chunked. This bypasses a bug wherearchivermiscalculates the size of the multipart body, which causes Express to drop the connection due toContent-Lengthheader mismatches.Related issue
test.shintegration suite that was previously failing with anAxiosError: Request failed with status code 400when executingmetacall-deploy --dev.Type of change
How to test
fix/deploy-protocol-patchsudo docker compose down --remove-orphans && sudo docker compose up --build --exit-code-from test5(Axios 400 Bad Request).Checklist
Notes for reviewers
This patch is applied using a sed replacement inside the
Dockerfilespecifically in theteststage. It does not affect the productionfaasruntime image overhead in any way.Release notes
Fixed Content-Length header mismatch bug crashing
metacall-deploy --devin FaaS integration tests.