docs: qualify --silent by Symfony version + document all three CLI lists (follow-up to #49) - #50
Merged
Merged
Conversation
…lists - README: --silent is a Symfony Console 7.2+ option, but composer.json still allows symfony/console ^6.4 || ^7.0, so consumers on 6.4/7.0/7.1 do not have it. Qualify the option with its minimum Console version and note the shipped Docker image includes it while older library installs may not. - Maintainer skill: adding a CLI command/option requires updating all three lists in update-cli-reference.sh (bash PROJECT_COMMANDS, node projectCommands, optionAllowlist), not just two; a command needs both command arrays or the generator silently skips it while the drift check still passes. Follow-up to Codex review on #49. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EanqRNh4A3XoojYr7MNFvd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cb51f9187
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mesilov
added a commit
that referenced
this pull request
Sep 3, 2026
…rator docs: harden CLI reference generator (root-cause fix for #50 review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second follow-up landing the Codex review points raised on #49 (which merged before the review completed). Both are confirmed valid.
--silentversion qualification —--silentwas introduced in Symfony Console 7.2, butcomposer.jsonallowssymfony/console: ^6.4 || ^7.0 || 8.0.*, so library consumers resolving 6.4/7.0/7.1 do not have the flag. The README now qualifies--silentwith its minimum Console version and notes the shipped Docker image includes it while older library installs may not.PROJECT_COMMANDS/optionAllowlist. Adding a command also requires the nodeprojectCommandsarray inupdate-cli-reference.sh(the generator loops over it), otherwise the command is silently skipped while the drift check still passes. The note now lists all three arrays and which are needed for a new command vs a new option.No CLI behavior changes; generated
cli.mdunchanged (drift check green).Verification
All green in the Docker dev environment:
make lint-openspec— 17 passed, 0 failedgit diff --check— cleanmake test-unit— 220 tests, 570 assertions OKmake lint-all—lint-agent-plugins(CLI drift check) passed, CS Fixer (0 fixable), PHPStan level 8 (no errors), Rector (done)Relates to #46. Review threads on #49 replied to and resolved.
🤖 Generated with Claude Code