docs: align OpenSpec + changelog with CLI-reference work (fixes #51 P1 review) - #52
Merged
Merged
Conversation
… CLI work Address the maintainer-policy gaps raised by Codex on #51: - Update the active `document-cli-option-reference` OpenSpec change so its proposal, design, tasks, and spec cover the review refinements (`--json` scope, `--silent` version) and the generator hardening (single-sourced command list, clear error on a missing optionAllowlist entry). - Add the missing `[Unreleased]` CHANGELOG entries for the generator hardening and the README CLI-reference corrections. Follow-up to Codex review on #51. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EanqRNh4A3XoojYr7MNFvd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3276bdafd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…n in spec - CHANGELOG: move the CLI-reference generator hardening and README-reference corrections from [Unreleased] into the not-yet-released [0.4.0] section (generator hardening under Changed; --json/--silent accuracy folded into the existing CLI-reference Added entry). [Unreleased] is empty again. - OpenSpec spec: align the "README Documents the Complete CLI Option Reference" requirement and scenario with the scoped --json (Echo commands only, not Symfony's built-in list/help), matching the proposal and implementation. Follow-up to Codex review on #52. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EanqRNh4A3XoojYr7MNFvd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the two P1 maintainer-policy gaps Codex raised on #51. My earlier follow-up PRs (#49/#50/#51) changed generator behavior and maintainer guidance without updating the active OpenSpec change or the changelog — both required by the repo's maintainer policy. This PR brings them into alignment.
document-cli-option-referencechange so it matches what shipped:proposal.md: added the--json/--silentrefinements and the generator hardening to "What Changes"; addedupdate-cli-reference.shto the affected files.design.md: recorded the version/scope qualification and the single-source + fail-clearly generator decisions.tasks.md: added "Review refinements" and "Generator hardening" task groups.spec.md: added a requirement that the generator is resilient (single-sourced command list; clear error on a missing allowlist entry).[Unreleased]entries for the generator hardening and the README CLI-reference corrections.No code/behavior changes here;
cli.mdunchanged, drift check green.Verification
openspec validate document-cli-option-reference --strict— validmake lint-openspec— 17 passed, 0 failedgit diff --check— cleanmake test-unit— 220 tests, 570 assertions OKmake lint-all—lint-agent-pluginspassed, CS Fixer (0 fixable), PHPStan level 8 (no errors), Rector (done)Relates to #46. Review threads on #51 replied to and resolved.
🤖 Generated with Claude Code