docs: harden CLI reference generator (root-cause fix for #50 review) - #51
Merged
Merged
Conversation
…issing allowlist Root-cause fix for the recurring CLI-reference maintenance pitfalls surfaced by Codex review: - update-cli-reference.sh now single-sources the command list: the node generator receives the shell PROJECT_COMMANDS array as arguments instead of keeping a duplicate hardcoded projectCommands list, so the two can no longer drift apart. - A command present in PROJECT_COMMANDS but missing an optionAllowlist entry now fails with a clear, actionable message instead of crashing on "undefined is not iterable". - Maintainer skill: simplify the "Изменения CLI" note to the two remaining lists (PROJECT_COMMANDS + optionAllowlist) and state that every command needs an allowlist entry (at least ["json"]). Regenerated cli.md is byte-identical; the drift check stays green. Follow-up to Codex review on #50. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EanqRNh4A3XoojYr7MNFvd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9a12ee098
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mesilov
added a commit
that referenced
this pull request
Sep 3, 2026
docs: align OpenSpec + changelog with CLI-reference work (fixes #51 P1 review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root-cause fix for the recurring
update-cli-reference.shmaintenance pitfalls that successive Codex reviews kept surfacing. Instead of documenting more manual caveats, this hardens the generator so the fragile steps go away.PROJECT_COMMANDSarray as arguments instead of keeping a duplicate hardcodedprojectCommands. The two lists can no longer drift apart (this was the docs: address Codex review on CLI reference (follow-up to #47) #49 finding).PROJECT_COMMANDSwithout anoptionAllowlistentry now fails with an actionable message (Command X has no optionAllowlist entry ... add one (at least ["json"])) instead of aborting onundefined is not iterable(this was the docs: qualify --silent by Symfony version + document all three CLI lists (follow-up to #49) #50 finding).PROJECT_COMMANDS+optionAllowlist) and states every command needs an allowlist entry.Regenerated
cli.mdis byte-identical to the committed file; the drift check stays green.Verification
All green in the Docker dev environment:
cli.mdvia the modified script →diffidentical to committed referencemake lint-openspec— 17 passed, 0 failedgit diff --check— cleanmake test-unit— 220 tests, 570 assertions OKmake lint-all—lint-agent-plugins(CLI drift check) passed, CS Fixer (0 fixable), PHPStan level 8 (no errors), Rector (done)Relates to #46. Review thread on #50 replied to and resolved.
🤖 Generated with Claude Code