Phase A0: tooling & CI foundation (ruff · mypy · coverage · frontend tests) - #4
Merged
Merged
Conversation
… debt Phase A0 of the OVERWATCH 10x roadmap (docs/superpowers/specs/2026-06-19-overwatch-10x-design.md). Tooling: - pyproject: ruff (E4/E7/E9/F), mypy (pragmatic, ignore-missing-imports), coverage config - CI split into backend (ruff + mypy + pytest w/ 40% coverage floor) and frontend (jest/RTL + eslint-via-build) jobs - frontend: add @testing-library/react + jest-dom, setupTests, smoke tests (entities + ConnectionStatus); add test:ci script Fixes surfaced by the gates (no behaviour change): - ruff: remove unused imports, replace 4 bare excepts, drop dead vars - mypy: fix undefined PerceptionSnapshot in ports.py; guard None model/detector access in detection_adapter; correct gather() exception-union handling; remove no-op env_parse_json SettingsConfigDict key - frontend: remove unused WebSocketEvents/useCallback imports and dead handleToggle 57 backend tests + 12 frontend tests green; ruff + mypy clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
First chunk of the OVERWATCH 10× roadmap (see
docs/superpowers/specs/2026-06-19-overwatch-10x-design.md). This PR establishes the comprehensive verification gate that every subsequent PR must clear — nothing else can be trusted until the gate exists.Changes
Tooling (
pyproject.toml)rufflint config (E4/E7/E9/F,scripts/archive/excluded)mypyconfig (pragmatic baseline:ignore_missing_imports,check_untyped_defs)coverageconfig (branch coverage onapp)CI (
.github/workflows/ci.yml) — split into two jobs:ruff→mypy→pytestwith a 40 % coverage floornpm ci→jest/RTL →npm run build(eslint runs in build,CI=true)Frontend test infra (none existed)
@testing-library/react+@testing-library/jest-dom,src/setupTests.jsentities.test.js, incl. IoU math) + aConnectionStatusrender testtest:ciscriptDebt the gates surfaced (no behaviour change)
ruff: removed unused imports, replaced 4 bareexcept:, dropped dead varsmypy(fixed 3 genuine latent issues): undefinedPerceptionSnapshotinports.py; unguardedNonemodel/detector access indetection_adapter;asyncio.gatherBaseException-union handling. Also removed the no-openv_parse_jsonSettingsConfigDictkey (not a real option in installed pydantic-settings).WebSocketEvents/useCallbackimports and the deadhandleToggleVerification (local)
ruff check backend scripts→ cleanmypy→ clean (16 files)pytest backend/tests/unit→ 57 passed, coverage 42.35 %npm run test:ci→ 12 passed (2 suites);npm run build→ compiles, eslint cleanNotes
I/UP/Bland in a later quality PR to keep this diff reviewable.🤖 Generated with Claude Code