Phase A4: cover broadcast serialization + raise coverage floor to 50% - #8
Closed
mandarwagh9 wants to merge 1 commit into
Closed
mandarwagh9 wants to merge 1 commit into
mandarwagh9 wants to merge 1 commit into
Conversation
Phase A4 of the 10x roadmap — completes Phase A (the honest & solid base). - Add msgpack round-trip tests for WebSocketCommunicationRepository._serialize_* (snapshot envelope, JPEG frame encoding, detection/track/world-object/prediction shapes, empty snapshot). This pins the exact wire format the frontend decodes. - CI: install fastapi + msgpack (needed to import the ws adapter) and raise the coverage floor 40% -> 50%. websocket_adapter 0%->46%, total 49%->52%. ruff/mypy clean, 74 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 19, 2026
Owner
Author
|
Superseded — all commits from this phase landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Phase A4 of the 10× roadmap — completes Phase A (the honest, tested base). Targets the biggest untested module: the WebSocket broadcast serialization (was 0% covered) that produces the exact wire format the frontend decodes.
Changes
test_websocket_serialization.py— msgpack round-trip tests for_serialize_snapshotand every per-entity serializer: snapshot envelope, JPEG frame encoding (asserts theFF D8SOI marker), detection/track/world-object/prediction shapes, and the empty-snapshot case.fastapi+msgpack(required to import the ws adapter) and raise the coverage floor 40% → 50%.Verification
ruffclean ·mypyclean · 74 tests pass (was 67).websocket_adapter0% → 46%, total 49% → 52% (floor now 50%).📍 Phase A complete
With this PR, Phase A (honest & solid) is done across #4–#8: tooling/CI gate, honest docs, world-model no-op fix, tracking hardening, and coverage lift. Recommend merging the stack from #4 down before Phase B (the actual feature builds) begins.
🤖 Generated with Claude Code