Phase A2: world-model auto-default calibration (fix silent no-op) - #6
Closed
mandarwagh9 wants to merge 1 commit into
Closed
mandarwagh9 wants to merge 1 commit into
mandarwagh9 wants to merge 1 commit into
Conversation
…AMERA_POSITIONS Phase A2 of the 10x roadmap. Previously, with no CAMERA_POSITIONS configured, pixel_to_world() returned None for every camera, so the world model produced ZERO world objects and ZERO predictions — viewers saw only raw detections and per-camera tracks, and the "fusion" layer silently no-opped. - Add WorldModelRepositoryImpl._ensure_calibration(): lazily synthesize a default calibration (cameras spread along x-axis, height 2.5 m, focal 800) when a camera has none, with a one-time warning. Explicit CAMERA_POSITIONS still take precedence. - Wire it into _process_track and generate_predictions so both track fusion and view-only prediction cameras work out of the box. - Tests: 4 new (objects created without config; lazy creation for unseen camera; explicit positions win; predictions don't raise for a second camera). - Docs: backend/ARCHITECTURE.md no longer claims CAMERA_POSITIONS is required. Backend gate green: ruff + mypy clean, 61 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 19, 2026
Owner
Author
|
Superseded — all commits from this phase landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Phase A2 of the 10× roadmap — the highest-impact correctness fix in Phase A.
The bug: with no
CAMERA_POSITIONSconfigured,pixel_to_world()returnedNonefor every camera, so the world model produced zero world objects and zero predictions. The entire fusion layer silently no-opped — viewers saw only raw detections and per-camera tracks.Changes
WorldModelRepositoryImpl._ensure_calibration()— lazily synthesizes a default calibration (cameras spread along x-axis, height 2.5 m, focal 800) when a camera has none, with a one-time warning. ExplicitCAMERA_POSITIONSstill take precedence._process_trackandgenerate_predictions, so both track fusion and view-only prediction cameras work out of the box.backend/ARCHITECTURE.md:CAMERA_POSITIONSis now documented as recommended (auto-defaulted), not required.Tests (TDD — written first, watched fail, then implemented)
4 new tests in
test_world_model_auto_calibration.py:CAMERA_POSITIONSCAMERA_POSITIONStake precedence over the defaultgenerate_predictionsfor a second camera doesn't raiseVerification
ruffclean ·mypyclean (16 files) · 61 tests pass (was 57).🤖 Generated with Claude Code