Serve editor.ui.k8s.appscode.com EditorTemplate (fast, values-driven)#430
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
tamalsaha
force-pushed
the
editor-ui-template
branch
from
a47f9c6 to
ee99adc
Compare
This was referenced Jun 26, 2026
tamalsaha
force-pushed
the
editor-ui-template
branch
from
ee99adc to
07fd8db
Compare
…ven) Add a registry storage for the editor.ui.k8s.appscode.com EditorTemplate kind. It reconstructs an installation's editor model/manifest/resources from the chart values supplied in the request via editor.EditorChartValueManifest -- only fast in-cluster reads, so it stays within the aggregated apiserver request budget. The slow parts (pulling the chart and creating the AppRelease) are done by the caller (b3), so this storage uses neither a chart registry nor a rest.Config. Pins resource-metadata and lib-app to master (EditorTemplate carries chart values; EditorChartValueManifest takes a values map). Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
editor-ui-template
branch
from
07fd8db to
10acfe4
Compare
tamalsaha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Serves the
editor.ui.k8s.appscode.comEditorTemplate kind from kube-ui-server. Given an installation's metadata and the editor chart's values, it reconstructs the editor model / manifest / resources viaeditor.EditorChartValueManifestand returns them.Design: keep kube-ui-server fast
The storage does only fast in-cluster reads (
kc.Get(AppRelease)+EditorChartValueManifest), so it stays within the aggregated apiserver request budget (~30s). The slow/mutating parts are intentionally left to the caller (b3):Accordingly this storage uses neither a chart registry nor a rest.Config — it just consumes the
valuesfrom the request.New API group block
Registered under a dedicated
editor.ui.k8s.appscode.comAPI group (needs the matching APIService + RBAC from the installer — see kubeops/installer#493).Depends on (both merged)
EditorTemplateRequestcarries chartValues.EditorChartValueManifesttakes a values map.go.mod pins resource-metadata and lib-app to their merged master commits.
Part of a multi-repo change with appscode-cloud/b3#1527 (does getChart + CreateAppRelease, sends values).