editor: pass chart values to EditorChartValueManifest#173
Merged
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Change exported EditorChartValueManifest to accept the chart values (map[string]any) instead of the whole *chart.Chart, and update loadEditorModel to pass chrt.Chart.Values. Drops the helm.sh/helm/v3/pkg/chart dependency from this path. Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
editor-ui-template
branch
from
db80177 to
0fe5ede
Compare
tamalsaha
changed the title
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors
pkg/editor/chart_template.goso the editor model/manifest/resources are reconstructed from a chart's values map rather than a full*chart.Chart:EditorChartValueManifestto acceptvalues map[string]anyinstead ofchrt *chart.Chart.loadEditorModelto passchrt.Chart.Values.helm.sh/helm/v3/pkg/chartimport from this path.go build ./...passes; the only caller is updated.Why
Building block for the
EditorTemplateaggregated API (editor.ui.k8s.appscode.com), which reconstructs an installation's editor view from values.Related