Skip OpenAPI model-building for editor EditorModels#433
Merged
Conversation
The editor.ui.k8s.appscode.com EditorModel storage was added to the aggregated apiserver, but its resource path was never added to ignorePrefixes. At startup the apiserver builds structured-merge OpenAPI models for every served resource not in ignorePrefixes; EditorModel's schema transitively references types (e.g. x-helm.dev/apimachinery/apis/releases/v1alpha1.Metadata) whose OpenAPI definitions are not available, so model-building fatal-exits and the server crashloops. Add the editormodels path to ignorePrefixes, matching every other synthesized/non-persisted aggregated resource served here. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kube-ui-servercrashlooped at startup:unable to get openapi models: cannot find model definition for ...EditorModel— the newly-addededitormodelsstorage was never added toignorePrefixes, so the apiserver tried to build OpenAPI models for it.EditorModel's schema transitively references types (e.g.releases/v1alpha1.Metadata) whose definitions aren't available, so model-building fatal-exits.Fix: add the
editormodelspath toignorePrefixeslike every other synthesized aggregated resource. Verified on a live cluster — pod1/1 Running, 0 restarts.