Skip to content

Restyle settings as Riverbank's modal - #8

Merged
sanjaydotpro merged 9 commits into
mainfrom
riverbank/settings-modal
Nov 17, 2026
Merged

sanjaydotpro merged 9 commits into
mainfrom
riverbank/settings-modal

Conversation

@sanjaydotpro

@sanjaydotpro sanjaydotpro commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Restyles the desktop settings dialog to the final Riverbank artboard in Paper (6EV-0, page "Final · Riverbank dark"). Part of HIS-11, stacked on #7 (which is stacked on #6). Every modal now dims with the palette's scrim, set once in the dialog theme.

Paper (left) and the app (right) at 1440×900, cropped to the modal

The modal. It's now 820×700 with radius 18, a 1px #35312B edge, black-only shadows, and the theme's 70% scrim behind it. On a smaller window it shrinks to the window less a 24pt margin. Below 560pt wide (never on Windows) it stacks into one list under the same header.

Nav column. It's 224pt wide on the canvas colour with a #2C2924 edge. From top to bottom: "Settings" in Shantell 17/600, a 34pt search field (radius 10, 1.5px border), and the sections in Paper's order. Each section row is 32pt high with radius 9; the selected one is sage tonal. At the foot is "Version 1.29 · Up to date" with a sage dot, which turns clay when an update is waiting. The rail has its own icons (SettingsSection.railIcon), so the phone's category list is unchanged.

Pane. The header shows the section title (Shantell 20/600), its summary in #9C9485, and a tonal "Done esc" button. Below it, the groups have Shantell 14/600 headings in sentence case, 20pt between groups, and cards in #292621 with a 1px #312D27 outline drawn inside the box. Rows are at least 54pt high, with 17pt icons, a Figtree 13.5/600 title and a 12/400 description. Dividers are inset 43pt. Switches are 34×20 with a 16pt knob. Reset is a 28pt control button. A 64pt fade sits at the foot of the pane.

Shared parts. SettingsLabel, SettingsGroup, the row metrics, the switch and the row button change only with a pointer. A phone still sets group labels in small capitals; callers now pass sentence case, and the phone uppercases it. Windows keeps its half-point-larger row type, from AppTypeScale.

Copy and icons. "Panel widths" now reads "Reset the notes list to its default width", as Paper does; it becomes fully accurate once #5 removes the results column. The font note says menus keep the app font, now that #6 bundles Figtree. The General rows use Paper's icons: text cursor, spell check, hashtag, upload, lock key, computer, sidebar and columns. Those icons also appear on the phone's General page, the only phone pixels this PR changes (phone_settings_general.png).

Tokens. Seven new palette tokens, with dark values from Paper and light values derived: textHeading, textSubheading, textMuted, textDescription, cardBackground, paneEdge, switchTrackOff. Light values are provisional until the light proposal is approved.

Where it still differs from Paper:

  • Profile & sync and Plan & usage appear only with an account, as before. The comparison fixture has no account, so they're missing from the render.
  • The search field is focused when settings opens, so it shows the focus border; Paper draws it at rest.
  • Text is about 1pt lower overall, and Flutter rasterizes glyphs slightly heavier than the browser does.

Tests. Desktop test expectations follow the new labels, sizes and the Dialog. The weights test now asserts Riverbank's weights instead of "regular or lighter". Eight settings goldens are regenerated.

Verified on Flutter 3.47.4 (~/dev/flutter, because the repo's 3.47.2 install on this Mac is damaged), with flutter pub get --enforce-lockfile:

  • flutter analyze is clean.
  • app_test, golden_test, settings_search_test, settings_sheet_test, update_ui_test, test/sync and test/speech pass.

Open in Capy

sanjaydotpro and others added 7 commits November 16, 2026 22:14
The desktop dialog becomes the 820x700 modal from Paper's final page:
a nav column with the title, search and the seven sections, and a pane
with its heading, summary and Done esc, grouped cards of 54pt rows,
Riverbank switches and a fade at the foot. Group headings move to
sentence case and the phone keeps its small capitals.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…riverbank/settings-modal

# Conflicts:
#	lib/core/theme.dart
#	test/goldens/desktop_dark_settings.png
#	test/goldens/desktop_dark_settings_appearance_end.png
#	test/goldens/desktop_dark_settings_shortcuts.png
#	test/goldens/desktop_dark_settings_updates.png
#	test/goldens/desktop_light_settings_appearance.png
#	test/goldens/desktop_windows_dark_settings.png
#	test/goldens/desktop_windows_dark_update.png
@sanjaydotpro
sanjaydotpro changed the base branch from riverbank/1-foundation to riverbank/3-window-layout November 16, 2026 17:00
@sanjaydotpro
sanjaydotpro changed the base branch from riverbank/3-window-layout to main November 17, 2026 03:50
@sanjaydotpro
sanjaydotpro merged commit 55abe28 into main Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant