Repository navigation
Restyle settings as Riverbank's modal - #8
Merged
Merged
Conversation
The desktop dialog becomes the 820x700 modal from Paper's final page: a nav column with the title, search and the seven sections, and a pane with its heading, summary and Done esc, grouped cards of 54pt rows, Riverbank switches and a fade at the foot. Group headings move to sentence case and the phone keeps its small capitals.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…erbank/settings-modal
…riverbank/settings-modal # Conflicts: # lib/core/theme.dart # test/goldens/desktop_dark_settings.png # test/goldens/desktop_dark_settings_appearance_end.png # test/goldens/desktop_dark_settings_shortcuts.png # test/goldens/desktop_dark_settings_updates.png # test/goldens/desktop_light_settings_appearance.png # test/goldens/desktop_windows_dark_settings.png # test/goldens/desktop_windows_dark_update.png
sanjaydotpro
changed the base branch from
riverbank/1-foundation
to
riverbank/3-window-layout
November 16, 2026 17:00
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restyles the desktop settings dialog to the final Riverbank artboard in Paper (
6EV-0, page "Final · Riverbank dark"). Part of HIS-11, stacked on #7 (which is stacked on #6). Every modal now dims with the palette's scrim, set once in the dialog theme.The modal. It's now 820×700 with radius 18, a 1px #35312B edge, black-only shadows, and the theme's 70% scrim behind it. On a smaller window it shrinks to the window less a 24pt margin. Below 560pt wide (never on Windows) it stacks into one list under the same header.
Nav column. It's 224pt wide on the canvas colour with a #2C2924 edge. From top to bottom: "Settings" in Shantell 17/600, a 34pt search field (radius 10, 1.5px border), and the sections in Paper's order. Each section row is 32pt high with radius 9; the selected one is sage tonal. At the foot is "Version 1.29 · Up to date" with a sage dot, which turns clay when an update is waiting. The rail has its own icons (
SettingsSection.railIcon), so the phone's category list is unchanged.Pane. The header shows the section title (Shantell 20/600), its summary in #9C9485, and a tonal "Done esc" button. Below it, the groups have Shantell 14/600 headings in sentence case, 20pt between groups, and cards in #292621 with a 1px #312D27 outline drawn inside the box. Rows are at least 54pt high, with 17pt icons, a Figtree 13.5/600 title and a 12/400 description. Dividers are inset 43pt. Switches are 34×20 with a 16pt knob. Reset is a 28pt control button. A 64pt fade sits at the foot of the pane.
Shared parts.
SettingsLabel,SettingsGroup, the row metrics, the switch and the row button change only with a pointer. A phone still sets group labels in small capitals; callers now pass sentence case, and the phone uppercases it. Windows keeps its half-point-larger row type, fromAppTypeScale.Copy and icons. "Panel widths" now reads "Reset the notes list to its default width", as Paper does; it becomes fully accurate once #5 removes the results column. The font note says menus keep the app font, now that #6 bundles Figtree. The General rows use Paper's icons: text cursor, spell check, hashtag, upload, lock key, computer, sidebar and columns. Those icons also appear on the phone's General page, the only phone pixels this PR changes (
phone_settings_general.png).Tokens. Seven new palette tokens, with dark values from Paper and light values derived:
textHeading,textSubheading,textMuted,textDescription,cardBackground,paneEdge,switchTrackOff. Light values are provisional until the light proposal is approved.Where it still differs from Paper:
Tests. Desktop test expectations follow the new labels, sizes and the
Dialog. The weights test now asserts Riverbank's weights instead of "regular or lighter". Eight settings goldens are regenerated.Verified on Flutter 3.47.4 (
~/dev/flutter, because the repo's 3.47.2 install on this Mac is damaged), withflutter pub get --enforce-lockfile:flutter analyzeis clean.app_test,golden_test,settings_search_test,settings_sheet_test,update_ui_test,test/syncandtest/speechpass.