Repository navigation
Show calculation results at the ends of their lines - #5
Merged
Merged
Conversation
sanjaydotpro
force-pushed
the
riverbank/2-inline-results
branch
from
November 16, 2026 17:08
43fb886 to
aa51bcb
Compare
This was referenced Nov 16, 2026
On desktop each result is now a pill at the right-hand end of its line, on the line's last visual row, with a dotted leader from where the writing stops. The pills take Riverbank's result tokens, and a line that reads the total gets the strongest one. They are drawn over the field, never in its text, so the caret, selection, copy, paste and undo see only the note. The desktop results column goes, with its divider, restore handle, width preference and the colour-by-kind chip colouring. Cmd+R still hides and shows results, and the visibility preference moves to v2 so nobody starts with them hidden by the old column. Phones keep their fixed results column, its figures now in the result text colour. Goldens this alters are regenerated on Flutter 3.47.4.
sanjaydotpro
force-pushed
the
riverbank/2-inline-results
branch
from
November 17, 2026 04:03
aa51bcb to
1aabf46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the desktop results column with a pill at the end of each calculating line, as in the approved Riverbank design (HIS-8, part of HIS-6). Rebased onto main now that the redesign stack (#6, #7, #8, #9, #10 and #14) has landed.
Results at line ends
InlineResultslayer draws the pills over the field, using the same measurement the field lays out with.LineMeasurernow also returns the last row of each calculating line, and only for those lines.resultPillBackgroundandresultPillText(#2B3326 and #B3C79C in dark). The line that reads the running total gets the strongest pill,totalPillBackgroundandtotalPillText(#7D9468 and #1C1A17). That line istotalorsum, or a conversion of it such astotal in eur.AppTypeScale.resultis now 13 on every desktop, as in Paper; macOS was 12.5. Hover uses the theme'sfillStatesrecipe.textTertiaryat 30%, which comes out as #423E37 on the page; Paper's is #423D36.Editing is unchanged
The pills sit beside the text field rather than inside its text, so the caret, selection, copy, paste and undo only ever see the note. Copy-on-click, the "Couldn't copy" toast, error states, unit and currency formatting, and live updates all go through the same
ResultChipas before.What goes away
gutter.v1,gutterWidth,resetGutterWidth,GutterDivider,ResultsRestoreHandle, and theNoteEditorcallbacks and flags that fed them. Their three goldens go too.chipNumber,chipCurrency,chipUnit,chipBooleanorchipOther. The tokens themselves stay, because the update badges in the toolbar and sidebar, the settings update row, the confetti and the voice-note speaker colours still use them. HIS-15 takes over their names and colours.resultsVisible.v2. Without this, someone who had folded the old column away would update to no results and no handle to bring them back, so everyone starts with the pills shown.packaging/SUBMISSION.mdno longer describe a results gutter on desktop.Phones keep their fixed results column. The compact layout on iOS and Android passes
gutterWidthand keeps its structure, and its figures now useresultPillText. Desktop windows of every size get pills, and so does a tablet wide enough for the two-pane layout, because that layout used the same desktop column.Goldens
These were rendered on Flutter 3.47.4 (
~/dev/flutter), not the pinned 3.47.2, because the crew notes say the 3.47.2 SDK on this Mac is damaged and can't run tests. On main (77e39b8), every golden re-renders byte for byte on this Mac exceptdesktop_dark_note_pinned.png(see below), so every difference here comes from this change.desktop_dark_narrow_list.png, where the page shows under the listwelcome_phone_light.png, where only colour changes: its four figures go from #667254 toresultPillText#445A2F, with no pixel moved. The dark phone images are unchanged.desktop_dark_narrow_results.png: the 600×630 window, which keeps the Riverbank layout since Keep the Riverbank layout in narrow desktop windows #10, with results at the ends of its lines. I removed the three divider and restore-handle goldens, including Keep the Riverbank layout in narrow desktop windows #10'sdesktop_dark_narrow_results_divider_hover.png. Every golden passes.desktop_dark_note_pinned.pngcalculatesTodayagainst the real clock, so it changes every day.Verification
flutter analyzereports no issues. The whole suite passes on this Mac, goldens included: 2,125 tests, with 8 skipped. CI runs no tests.