Repository navigation
Build the notes list beside the rail as Riverbank's cards - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the notes list beside the spaces rail from Paper's final Riverbank page: the search field (636-0), the media filter and view toggle (62Q-0, with 6C3-0's default, open and narrowed states), Pinned (61E-0) and Notes (5YX-0). It covers HIS-12 and is stacked on #8, which is stacked on #7.
The list. Beside the rail, the sidebar now shows "Find a note…" with a ⌘F keycap. Under it is one row holding the All media dropdown and a list/cards toggle. Below that come Pinned, any shared spaces, and Notes. The list fades out into the canvas at the bottom. Pinned shows the four most recent pinned notes, with See all when there are more. See all lists every pinned note under a back chevron and switches the search to "Find in pinned…". While a search is running, Pinned isn't capped.
Cards and rows.
NoteRowgains astyle:compact(the phone layout, unchanged),roworcard. Every style uses the same click, Option-click, right-click, drag-to-pane, archive picking, presence and lock handling. Only the face differs:NoteGlancereads a note's line, result, checklist and media once per note version and caches it, so hover repaints don't split the body again.Media filter. Everything is ticked by default. Unticking types narrows the list to notes that hold a type still ticked, and the button then names the ticked types on the sage tonal fill. The last ticked type can't be unticked. The filter is session state in
home_page.dartand applies in_visibleNotes, so keyboard navigation follows what's on screen. The list/cards choice is saved asLayoutPrefs.noteCardsand defaults to cards.Supporting changes:
cardTitleandaccentText(See all's sage).filterRounded,listViewRoundedandgridViewRounded(0xE0D0–0xE0D2).SidebarTimestamp.glance.NotesStore.now(), so cards say "Today" by the store's clock.Where it differs from Paper:
Testing. On Flutter 3.47.4, because the repo's 3.47.2 install on this Mac is damaged:
flutter analyzeis clean andflutter testpasses (2119 passed, 8 skipped). New tests cover the media filter, See all, the view toggle andSidebarTimestamp.glance. The 16 desktop goldens are regenerated, and the phone goldens are unchanged.