Skip to content

Put the page on Riverbank's card with its own toolbar - #14

Merged
sanjaydotpro merged 2 commits into
mainfrom
riverbank/page-toolbar
Nov 17, 2026
Merged

sanjaydotpro merged 2 commits into
mainfrom
riverbank/page-toolbar

Conversation

@sanjaydotpro

Copy link
Copy Markdown
Contributor

Stacked on #10 (HIS-16). Part of HIS-10: the parts of Riverbank's editor page that sit outside lib/ui/editor/.

The page is a card. In the wide window, the notes page sits on Paper's card (5TU-0): #23201C fill, a 1.5px pageBorder edge, radius 20, and Paper's two black shadows. It clips everything on it to those corners. This adds two palette tokens, pageBorder and textDivider (the breadcrumb slash, #554F47). Their light values are placeholders until the light proposal lands.

The page has its own toolbar. PageToolbar replaces NoteToolbar in the wide layout (5YA-0 and 69R-0), at 56 tall with 24/16 insets:

  • The breadcrumb shows the space, then "Pinned" when the open note is pinned.
  • Saved reflects sync: Saved, Syncing, or Offline with a tooltip. It shows only while a note is open, and steps aside when the page is under 460 wide.
  • Share is a sage tonal button, 32 tall with radius 10.
  • The pin pins the open note, and turns clay while it is pinned.
  • More opens a menu with Split view (greyed with its reason when blocked), Keep on top (with its shortcut), then the note's own actions on the same terms as the list's menu: Move to Hidden Notes / Archive, Restore / Delete permanently, or Move to Notes.
  • "Update and restart" still appears there once a release has downloaded.
  • With the list folded away, the toolbar leads with Paper's show-list button (30×30, radius 8), which calls _toggleList, then a sage +, then a divider before the breadcrumb.

NoteToolbar is now phone-only. It loses its split button, and its New note tooltip reads the user's bound chord instead of a hard-coded ⌘N or Ctrl+N. The list's note-action rows move into context_menu.dart as KapyMenuAction and KapyMenuActionRow, so the list and More draw them the same way. An icon-only TonalButton now uses Paper's 15px, 2-stroke glyph.

Tests. The desktop app tests now drive the page toolbar. The header-mascot tests run on a phone, since that is now the only place the animated mark appears. page_toolbar_test.dart is new. The desktop goldens are re-rendered.

Against Paper at 1440×900, 6.1% of pixels differ with the list hidden (659-0) and 10.7% with it showing (5TS-0). Almost all of the remaining difference is the editor body, which is the separate styling PR.

Paper (left) vs app (right), list hidden

Paper (left) vs app (right), main window

Not in this PR. Kapy peeking from the page corner moves to the editor styling PR. The footer's "Total:" sits in that corner until the insert bar replaces the footer, and Kapy would cover it.

Verified with Flutter 3.47.4 (~/dev/flutter, pub get --enforce-lockfile), because this Mac's 3.47.2 install is damaged. flutter analyze is clean, and flutter test passes (2128 passed, 8 skipped).

Open in Capy

@sanjaydotpro
sanjaydotpro changed the base branch from riverbank/3b-narrow-window to main November 17, 2026 03:51
@sanjaydotpro
sanjaydotpro merged commit 77e39b8 into main Nov 17, 2026
4 checks passed
@sanjaydotpro
sanjaydotpro deleted the riverbank/page-toolbar branch November 17, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant