Repository navigation
Put the page on Riverbank's card with its own toolbar - #14
Merged
Merged
Conversation
sanjaydotpro
changed the base branch from
riverbank/3b-narrow-window
to
main
November 17, 2026 03:51
This was referenced Nov 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #10 (HIS-16). Part of HIS-10: the parts of Riverbank's editor page that sit outside
lib/ui/editor/.The page is a card. In the wide window, the notes page sits on Paper's card (5TU-0):
#23201Cfill, a 1.5pxpageBorderedge, radius 20, and Paper's two black shadows. It clips everything on it to those corners. This adds two palette tokens,pageBorderandtextDivider(the breadcrumb slash,#554F47). Their light values are placeholders until the light proposal lands.The page has its own toolbar.
PageToolbarreplacesNoteToolbarin the wide layout (5YA-0 and 69R-0), at 56 tall with 24/16 insets:_toggleList, then a sage +, then a divider before the breadcrumb.NoteToolbar is now phone-only. It loses its split button, and its New note tooltip reads the user's bound chord instead of a hard-coded ⌘N or Ctrl+N. The list's note-action rows move into
context_menu.dartasKapyMenuActionandKapyMenuActionRow, so the list and More draw them the same way. An icon-onlyTonalButtonnow uses Paper's 15px, 2-stroke glyph.Tests. The desktop app tests now drive the page toolbar. The header-mascot tests run on a phone, since that is now the only place the animated mark appears.
page_toolbar_test.dartis new. The desktop goldens are re-rendered.Against Paper at 1440×900, 6.1% of pixels differ with the list hidden (659-0) and 10.7% with it showing (5TS-0). Almost all of the remaining difference is the editor body, which is the separate styling PR.
Not in this PR. Kapy peeking from the page corner moves to the editor styling PR. The footer's "Total:" sits in that corner until the insert bar replaces the footer, and Kapy would cover it.
Verified with Flutter 3.47.4 (
~/dev/flutter,pub get --enforce-lockfile), because this Mac's 3.47.2 install is damaged.flutter analyzeis clean, andflutter testpasses (2128 passed, 8 skipped).