Repository navigation
Riverbank light palette - #16
Merged
Merged
Conversation
Replace every light token with the approved p-3-1 values, make the sage 56703C the light accent, drop the old copper brand colour, and route the hard-coded black shadows and the switch thumb through the palette so light mode casts ink-brown shadows. Re-render the light goldens it moves.
In transparency mode the page card painted its own translucent paper under the editor, gutter and footer, which paint theirs, and its drop shadow showed through the page as a dark slab. The card is now only its edge in glass mode, and the page toolbar paints the paper it sits on.
The engine read DateTime.now while the notes, their cards and the goldens read the notes store's clock, so a golden with "Today" in its note changed every day. The engine now takes the same clock, which pins desktop_dark_note_pinned to the golden date.
Opaque, the card's own fill is already under it, and a second fill moved the anti-aliasing where it meets the card's edge.
sanjaydotpro
force-pushed
the
riverbank/light-palette
branch
from
November 17, 2026 04:49
42b9e7e to
3f5bbed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the app's placeholder light palette with Riverbank light, the values Sanjay approved on Paper page p-3-1 (file 01M7HGSWEAH0VTGM4PQWD1H3HS, artboards 74I-1, 84C-1, 7MT-1, 71Q-1 and the token table 8B6-1). Dark mode is untouched.
Palette. Every
lightPalettetoken now carries its p-3-1 value. That means warm paper surfaces (FCFAF4 editor, F3EFE4 sidebar, F6F2E8 cards), ink-brown text (2A2620 / 6F695C / 8A8476) and the deeper sage 56703C as the light accent, with FCFAF4 on it. The old cool light values and the copperKapyTheme.brandare deleted rather than kept alongside, and the ColorScheme now seeds from the active accent in both modes.hover(EBE5D6) andselectedBackground(E2DCCB) aren't rows in the p-3-1 table, so they were picked to sit between the control and pane tones.Shadows. The page card, note cards, view toggle, settings dialog, switch knob and sidebar popover used hard-coded black shadows that would stay black on paper. They now go through a new
shadowpalette token viapalette.shadowAt(alpha), wherealphais the old black alpha. In dark mode the token is opaque black, so every shadow is byte-for-byte what it was. In light mode the token is ink 2A2620 at 40%, so 4D → 1F and 33 → 14, as in the proposal. The proposal flattens a few others further (80 → 29, 40 → 0D), and those come out slightly stronger here (33 and 1A). A newswitchThumbtoken gives the desktop switch its paper-coloured thumb on the sage track in light mode. In dark mode it's E2DCCF, the same as before. Instant capture'sWidgetsAppcolour now reads the light editor background instead of a leftover hex value.Goldens. The eight light goldens this moves are re-rendered: desktop light, light settings, sidebar streak, toast, shared-note toolbar, phone welcome and both Pro sheet goldens. No dark golden changes. The phone goldens move because iOS and Android share the light palette. Only colours change there, not layout.
Glass. I rendered light transparency over a wallpaper offscreen at both ends of the slider, and its tints are the Riverbank light tokens at reduced alpha. The renders also showed a layering bug that #14's page card brought in for both themes. The card painted its own translucent paper under the editor, gutter and footer, which already paint theirs, so the glass came out thicker than designed. Its drop shadow also showed through the page as a dark slab. Now in glass mode the card is only its edge, and the page toolbar paints the paper it sits on. That matches the layering from before #14. Opaque rendering is unchanged.
Clock. The calculator now reads the notes store's clock instead of
DateTime.now. In the app that clock is stillDateTime.now. The goldens already pin it, sodesktop_dark_note_pinnedno longer changes with the date: "Today" in its note now renders 1 Sep 2026.Verification. I ran these on Sanjay's Mac with Flutter 3.47.4 (
~/dev/flutter; the 3.47.2 install there is damaged), afterflutter pub get --enforce-lockfile.flutter analyzeis clean, and the fullflutter testsuite passes: 2131 tests.