Skip to content

Bound reverse DNS during wizard discovery - #42

Merged
jacobyoby merged 1 commit into
fix/issue-15-interface-selectionfrom
fix/issue-16-dns-timeout
Sep 9, 2026
Merged

jacobyoby merged 1 commit into
fix/issue-15-interface-selectionfrom
fix/issue-16-dns-timeout

Conversation

@jacobyoby

Copy link
Copy Markdown
Owner

The wizard used synchronous reverse DNS after each successful ping, so one slow resolver could hold a parallel scan runspace indefinitely.

This change routes wizard lookups through the module's asynchronous resolver with a configurable -DnsTimeoutSeconds deadline. Parallel runspaces load the module once when needed, and failed or timed-out lookups preserve the discovered IP with the existing Device-<IP> fallback hostname. The DNS task wait is now a private seam shared by Resolve-IPHostname and deterministic timeout/fault tests.

Validation: git diff --check passed. Tests use incomplete and faulted local tasks without public DNS, including a 1-second deadline with scheduling tolerance. PowerShell is unavailable on the local host; GitHub Actions will provide three-OS Pester and analyzer validation.

This PR is stacked on #33, which is stacked on #23, to keep overlapping wizard and test changes reviewable.

Closes #16

@jacobyoby
jacobyoby force-pushed the fix/issue-16-dns-timeout branch from 36e3a7c to c7de3c5 Compare September 8, 2026 21:32
@jacobyoby
jacobyoby merged commit 494477c into fix/issue-15-interface-selection Sep 9, 2026
1 check passed
@jacobyoby
jacobyoby deleted the fix/issue-16-dns-timeout branch September 9, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant