Repository navigation
Bound reverse DNS during wizard discovery - #42
Merged
jacobyoby merged 1 commit intoSep 9, 2026
Merged
Conversation
12 tasks
jacobyoby
force-pushed
the
fix/issue-15-interface-selection
branch
from
September 8, 2026 21:32
ac17202 to
7247137
Compare
jacobyoby
force-pushed
the
fix/issue-16-dns-timeout
branch
from
September 8, 2026 21:32
36e3a7c to
c7de3c5
Compare
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wizard used synchronous reverse DNS after each successful ping, so one slow resolver could hold a parallel scan runspace indefinitely.
This change routes wizard lookups through the module's asynchronous resolver with a configurable
-DnsTimeoutSecondsdeadline. Parallel runspaces load the module once when needed, and failed or timed-out lookups preserve the discovered IP with the existingDevice-<IP>fallback hostname. The DNS task wait is now a private seam shared byResolve-IPHostnameand deterministic timeout/fault tests.Validation:
git diff --checkpassed. Tests use incomplete and faulted local tasks without public DNS, including a 1-second deadline with scheduling tolerance. PowerShell is unavailable on the local host; GitHub Actions will provide three-OS Pester and analyzer validation.This PR is stacked on #33, which is stacked on #23, to keep overlapping wizard and test changes reviewable.
Closes #16