Skip to content

P1: Bound reverse DNS work in the discovery wizard #16

Closed

Description

@jacobyoby

Review evidence

Reviewed main at 4a027ff72eda979b4ce62a798671aaa1cdc80e43. Source. Static review; PowerShell is not installed on the review host, so no local runtime reproduction is claimed.

The parallel discovery loop calls synchronous Dns.GetHostEntry after a successful ping. Unlike Resolve-IPHostname, this call has no explicit deadline, so slow DNS can stall scan completion.

Acceptance criteria

  • Use a bounded asynchronous lookup or the bounded resolver implementation, including inside parallel runspaces.
  • Preserve the discovered IP and a fallback hostname when DNS fails or times out.
  • Add deterministic slow/failing resolver tests proving completion within the configured deadline plus scheduling tolerance; avoid public DNS dependence.

Scope

Stable product readiness (the requested “1.0” roadmap). Existing package version is 1.3.0; do not reset semantic versions.

Activity

  1. added this to the 1.0 milestone on Sep 8, 2026
  2. jacobyoby commented on Sep 9, 2026

    @jacobyoby
    OwnerAuthor

    PR #42 merged in 494477c (via #52 stack). DNS now bounded via async resolver with -DnsTimeoutSeconds, parallel runspaces load module once, fallback hostname preserved. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions