Skip to content

Wizard: use tri-state reachability instead of Test-Connection -Quiet #64

Closed

Description

@jacobyoby

Context

#28 upgraded Test-DeviceReachability to tri-state (true / false / $null indeterminate) with optional -TcpFallbackPort, and DrawIO already renders Unknown gray vs Unreachable red.

The quick-start wizard still does:

$node.Reachable = Test-Connection ... -Quiet ...

That collapses local send failures and ICMP-blocked hosts into boolean $false, so firewalled routers discovered earlier in the wizard get painted Unreachable instead of Unknown — regressing the honesty #28 bought for the module API.

What

  • Route wizard connectivity checks through Test-DeviceReachability (or the same tri-state mapping).
  • Optionally expose -TcpFallbackPort on the wizard for ICMP-silent gateways.
  • Keep parallel discovery scan behavior bounded; do not remove -DnsTimeoutSeconds.

Acceptance criteria

  • Wizard step “[4/5] Testing connectivity” no longer assigns raw -Quiet booleans as the sole Reachable source for previously untested nodes.
  • A mocked/stubbed local-send failure yields $null (Unknown) rather than $false on affected nodes before export.
  • Reachable summary text distinguishes reachable vs unreachable vs unknown counts (or documents unknown separately).
  • Pester or fixture coverage for the wizard helper path if one exists; otherwise a focused module-level test of the shared helper the wizard calls.

Related

Follows #28. Adjacent to wizard work in #23 / #33 / #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions