IBX-12046: Removed the deprecated dbal.use_savepoints option from the test kernel config - #59
Merged
Merged
Conversation
…licitly in the test kernel config
…onentBundle is registered Projects get anonymous_template_directory and defaults from the symfony/ux-twig-component Flex recipe; test kernels don't, so the bundle deprecates the missing options in every consumer that registers it.
… test kernel config DBAL 4 always nests transactions with savepoints and DoctrineBundle 2.x deprecates the option (DoctrineBundle 3, required by Symfony 8, removes it). Its deprecation fired while the container compiled, before FrameworkBundle::boot() sets DOCTRINE_DEPRECATIONS=trigger, so doctrine/deprecations cached its mode as "none" and every Doctrine deprecation in the test run stayed silent. Without it, Doctrine deprecations reach the PHPUnit deprecation gate.
This was referenced Sep 24, 2026
Steveb-p
approved these changes
Sep 24, 2026
konradoboza
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
6.0.LegacyContentFilteringTestinphpunit-integration.xml)Description:
DBAL 4 always nests transactions with savepoints; DoctrineBundle 2.x deprecates
dbal.use_savepointsand DoctrineBundle 3 — required by Symfony 8 — removes it, so the key has to go before that switch.It also had a side effect: its deprecation fires while the container compiles, before
FrameworkBundle::boot()setsDOCTRINE_DEPRECATIONS=trigger. doctrine/deprecations caches its mode on the first trigger, so it cached "none" and every Doctrine deprecation in the test run stayed silent. Without the key, Doctrine deprecations reach the PHPUnit deprecation gate — the PRs above remove the ones that fire inside tests (DBALquoteIdentifier(), doctrine/collectionsCriteriawithout raw field access, core's legacy kernel config). Doctrine deprecations raised only while test-core'sBootstrapperinstalls the schema (ibexa/doctrine-schema's DBAL schema API use) fire before PHPUnit's handler and don't reach the gate.For QA:
No functional change. Swept all 53 gated repositories that use ibexa/test-core with this change installed (PHP 8.4, every gated config, Doctrine deprecation callers traced): the only callers reaching a gate are the ones fixed by the PRs above (seen in ibexa/core, ibexa/checkout, ibexa/connector-qualifio). Re-verified with the fixes installed: core's
phpunit-integration.xmlwith core#840 + core#841 exits 0 on PHP 8.3 and 8.4; the consumer baselines are regenerated separately.Documentation:
N/A