Skip to content

IBX-12046: Removed the deprecated dbal.use_savepoints option from the test kernel config - #59

Merged
ViniTou merged 4 commits into
6.0from
IBX-12046-dbal-use-savepoints
Sep 24, 2026
Merged

ViniTou merged 4 commits into
6.0from
IBX-12046-dbal-use-savepoints

Conversation

@ViniTou

@ViniTou ViniTou commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-12046

Related PRs:

Description:

DBAL 4 always nests transactions with savepoints; DoctrineBundle 2.x deprecates dbal.use_savepoints and DoctrineBundle 3 — required by Symfony 8 — removes it, so the key has to go before that switch.

It also had a side effect: its deprecation fires while the container compiles, before FrameworkBundle::boot() sets DOCTRINE_DEPRECATIONS=trigger. doctrine/deprecations caches its mode on the first trigger, so it cached "none" and every Doctrine deprecation in the test run stayed silent. Without the key, Doctrine deprecations reach the PHPUnit deprecation gate — the PRs above remove the ones that fire inside tests (DBAL quoteIdentifier(), doctrine/collections Criteria without raw field access, core's legacy kernel config). Doctrine deprecations raised only while test-core's Bootstrapper installs the schema (ibexa/doctrine-schema's DBAL schema API use) fire before PHPUnit's handler and don't reach the gate.

For QA:

No functional change. Swept all 53 gated repositories that use ibexa/test-core with this change installed (PHP 8.4, every gated config, Doctrine deprecation callers traced): the only callers reaching a gate are the ones fixed by the PRs above (seen in ibexa/core, ibexa/checkout, ibexa/connector-qualifio). Re-verified with the fixes installed: core's phpunit-integration.xml with core#840 + core#841 exits 0 on PHP 8.3 and 8.4; the consumer baselines are regenerated separately.

Documentation:

N/A

…onentBundle is registered

Projects get anonymous_template_directory and defaults from the symfony/ux-twig-component Flex recipe; test kernels don't, so the bundle deprecates the missing options in every consumer that registers it.
… test kernel config

DBAL 4 always nests transactions with savepoints and DoctrineBundle 2.x deprecates the option (DoctrineBundle 3, required by Symfony 8, removes it). Its deprecation fired while the container compiled, before FrameworkBundle::boot() sets DOCTRINE_DEPRECATIONS=trigger, so doctrine/deprecations cached its mode as "none" and every Doctrine deprecation in the test run stayed silent. Without it, Doctrine deprecations reach the PHPUnit deprecation gate.
@ViniTou
ViniTou merged commit 44ce783 into 6.0 Sep 24, 2026
8 checks passed
@ViniTou
ViniTou deleted the IBX-12046-dbal-use-savepoints branch September 24, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants