IBX-12046: Replaced deprecated DBAL quoteIdentifier() calls with quoteSingleIdentifier() - #841
Merged
Merged
Conversation
Steveb-p
approved these changes
Sep 24, 2026
konradoboza
approved these changes
Sep 24, 2026
…eSingleIdentifier() DBAL 4.4 deprecates Connection::quoteIdentifier() and AbstractPlatform::quoteIdentifier() in favor of quoteSingleIdentifier(), which quotes a single identifier part instead of splitting on dots. Qualified alias.column references are now built by quoting each part separately and concatenating with a literal dot, preserving the original generated SQL.
ViniTou
force-pushed
the
IBX-12046-dbal-quote-single-identifier
branch
from
September 24, 2026 10:56
ac6abf4 to
4c9c156
Compare
…upportedLanguagesTest.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
DBAL 4.4 deprecates
quoteIdentifier()("Use quoteSingleIdentifier() individually for each part of a qualified name instead", doctrine/dbal#6590). DoctrineBundle 3 — required by Symfony 8 — dropsdbal.use_savepoints, whose deprecation was what kept every Doctrine deprecation silent in our test kernels, so these calls must go before that switch.All 214 calls (19 files: legacy persistence gateways, field type storage gateways, legacy search sort clause and criterion handlers, the test
FixtureImporter) are replaced. Single, undotted identifiers — table constants, column literals, generated sort-table aliases (sort_table_…),$this->table— are swapped one-for-one; the literalalias.columnforms in the Image, Keyword, Url and User storage gateways (attr,img,kwd,url,usr,s) now quote only the column, as those aliases are used unquoted in the same queries. The generated SQL is identical.For QA:
No functional change. PHP 8.3 unit suite and PHP 8.4 integration + legacy integration suites (SQLite) exit 0; code style clean. PHPStan reports 7 errors in files this PR does not touch (
ISBN\Type,TransactionalInMemoryCacheAdapter,ContentName,LanguageServiceMaximumSupportedLanguagesTest). No remainingquoteIdentifier()calls insrc/ortests/.Documentation:
N/A