IBX-12046: Replaced deprecated DBAL quoteIdentifier() calls with quoteSingleIdentifier() - #358
Merged
Merged
Conversation
…eSingleIdentifier() DBAL 4.4 deprecates Connection::quoteIdentifier() in favor of quoteSingleIdentifier(), called once per part of a qualified name; all call sites here pass plain, non-dotted identifier literals, so the replacement is a direct rename with no semantic change.
|
konradoboza
approved these changes
Sep 24, 2026
Steveb-p
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
DBAL 4.4 deprecates
quoteIdentifier()("Use quoteSingleIdentifier() individually for each part of a qualified name instead", doctrine/dbal#6590). DoctrineBundle 3 — required by Symfony 8 — dropsdbal.use_savepoints, whose deprecation was what kept every Doctrine deprecation silent in our test kernels, so these calls must go before that switch.The two calls in
RichTextStorage\Gateway\DoctrineStorageand the two inRichTextFieldTypeIntegrationTestquote single, undotted column names and are replaced one-for-one; the generated SQL is identical.For QA:
No functional change. PHP 8.3 and 8.4, fresh
composer update: unit, integration and legacy integration suites exit 0 (the Solr legacy suite needs a live Solr server, fails identically without this change), PHPStan and code style clean. No remainingquoteIdentifier()calls; with ibexa/test-core#59 installed, all remaining callers are in ibexa/core.Documentation:
N/A