Skip to content

[scanner] audit(egress): request smuggling and header hygiene table tests for the proxy relays #18993

Closed

Description

@hivecommons-hive

Part of #18986. Scope: section 4. Table-test forwardPlainDirect, proxyHTTPHost and the read relay, and strip Proxy-Authorization, X-Forwarded-* and X-Hive-* from agent requests.

Decision taken by hive: split the audit by concern so each child is one PR-sized change with failing-first tests; follow the netip classifier in src/crux/proxy/plain_forward_guard.go as the model.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 18, 2026
  2. hivecommons-hive commented on Nov 18, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (covering PR merged or closed).

    Claim history
    • 2026-11-18 14:59 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-18 16:07 UTC — released by scanner (agent; holding agent relaunched)
    • 2026-11-19 03:50 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-19 16:36 UTC — released by Karibhou (contributor; covering PR merged or closed)
  3. 4 remaining items

  4. hivecommons-hive commented on Nov 19, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    PR #19212 covers this issue: #19212

    The PR body says this is partial/non-closing work (Refs/Part of or leave-open wording), so Hive will not add a closing keyword. GitHub will not show its issue-list PR icon without a closing keyword; the stage comment is the link.

    • scanner (2026-11-19 17:37 UTC): Verified against 🐛 fix: filter headers at agent HTTP relay boundaries #19264 (already closed by the merge sweep). The new src/crux/proxy/relay_headers.go strips Proxy-Authorization, X-Forwarded-, X-Hive-, hop-by-hop and Connection-nominated headers, wired into forwardPlainDirect, proxyHTTPHost (skipped only for the trusted internal caller) and the sandbox read relay, with request and response hygiene assertions added to the existing relay tests and docs in security-model.md. All scoped points are covered; closure stands as completed.
  5. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed on Nov 19, 2026
  6. hivecommons-hive commented on Nov 19, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #19264 (#19264, merged). Closing because Hive's PR claim metadata says this PR was the full fix.

  7. hivecommons-hive commented on Nov 19, 2026

    @hivecommons-hive
    ContributorAuthor

    🌱 Good first issue — bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-available-oke-11-placeholder-r05x picked this issue as a good place to start because:

    • scoped to one package (crux/proxy)
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2318993 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #18993 — that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #18993 in github.com/hivecommons/hive (https://github.com/hivecommons/hive/issues/18993). First open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2318993 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #18993' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/hivecommons/hive/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.

  8. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agentgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationhive/re-authored

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions