Skip to content

✨ dashboard: Settings control and MCP write for governor.ci workflow approval - #18953

Merged
hivecommons-hive[bot] merged 4 commits into
hivecommons:v6from
Danathar:feat/auto-approve-workflows-dashboard
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
hivecommons:v6from
Danathar:feat/auto-approve-workflows-dashboard

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary

governor.ci.auto_approve_workflows and governor.ci.auto_approve_workflow_actors (from #16603) were yaml-only; settings_parity_allowlist.txt marked both that way. So a hosted hive couldn't trust another bot without a config-file change. One example: github-actions[bot], for PRs a repository's own workflows open, such as metrics refreshes, promotions and ISO records. This PR gives both keys a Settings control and an admin-MCP write, and removes them from the allowlist. #16736, which added the keys, records no decision to keep them yaml-only.

What it adds

  • Features PUT/GET:
    • ciAutoApproveWorkflows is a boolean.
    • ciAutoApproveWorkflowActors is a comma-separated string, with the same convention as claimsNeverClaimLabels. Blank restores the default (dependabot[bot], renovate[bot]), and none stores an explicit [].
    • A login containing whitespace is refused.
    • GET also returns the default actor list for the placeholder.
  • Settings: a new Workflow approval subsection under Features → Auto-merge, with a toggle and a text field. Each has a YAML hint and help text; the help explains that a trusted author covers every run on the head. There's also a search entry.
  • Admin MCP: governor.feature_settings accepts both fields. Its widening disclosure names turning approval on and any change to the trusted actors other than none.
  • Docs: operator-reference/runtime-and-quota.md says where both controls live.

The approval sweep reads cfg.Governor.CI every cycle, so a change applies from the next eval cycle without a restart. The defaults are unchanged.

Related

Tests

  • TestGovernorFeaturesWorkflowApprovalRoundTrip: covers the flag and the list as typed, "none", blank (the default), and a refused login with whitespace.
  • TestWorkflowApprovalSettingsRender: checks the YAML hint and the control binding.
  • TestFeatureSettingsWorkflowApproval: checks the MCP body and the disclosure.
  • The existing settings parity test now finds both keys in the UI.

The bundle was rebuilt from static-src. gofmt -l is clean, and check-docs-citations.py verified 2163 references. Per AGENTS.md, nothing was built or tested locally; CI decides.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

…low approval

governor.ci.auto_approve_workflows and auto_approve_workflow_actors were
yaml-only (settings_parity_allowlist.txt), so a hosted hive could not, for
example, trust github-actions[bot] for its repositories' own workflow-opened
PRs without a config-file change.

- Features PUT/GET: ciAutoApproveWorkflows and ciAutoApproveWorkflowActors
  (comma-separated; blank = default, "none" = explicit empty list).
- Settings -> Features -> Auto-merge -> Workflow approval: a toggle and a
  text field with YAML hints and help, plus a search entry.
- Admin MCP governor.feature_settings accepts both and discloses turning
  approval on and changing the trusted actors.
- Both keys leave the parity allowlist.

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (7 waiting): fixes are handed out before new work as soon as you have capacity.

@Danathar Danathar changed the title feat(dashboard): Settings control and MCP write for governor.ci workflow approval ✨ dashboard: Settings control and MCP write for governor.ci workflow approval Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

This PR conflicts with v6 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18971 ✨ [v6] Cost card + admin MCP: tokens and spend per agent over a time window same files src/pkg/dashboard/static/index.html
#18945 🐛 automerge: name held workflow runs and stop base-refreshing them same files src/docs/operator-reference/runtime-and-quota.md

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@clubanderson clubanderson added the author/human A person pushed this PR themselves label Nov 18, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
Resolve the admin-MCP conflict with hivecommons#18948: keep both feature_settings
tests and name both knob groups in the operation description.

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@hivecommons-hive
hivecommons-hive Bot merged commit dc8d44a into hivecommons:v6 Nov 18, 2026
75 of 76 checks passed
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#18953d480022` sha256:a9b6ca9cf95274748c7a5951ba4f101951fafd57a09f60e11b1c3d9b16e5af65 — download from the dashboard or `hivectl review evidence #18953`.

merged by Hive trusted-author auto-merge: author Danathar holds role owner and GitHub permission maintain on repo; CI green at d480022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants