Repository navigation
✨ dashboard: Settings control and MCP write for governor.ci workflow approval - #18953
Conversation
…low approval governor.ci.auto_approve_workflows and auto_approve_workflow_actors were yaml-only (settings_parity_allowlist.txt), so a hosted hive could not, for example, trust github-actions[bot] for its repositories' own workflow-opened PRs without a config-file change. - Features PUT/GET: ciAutoApproveWorkflows and ciAutoApproveWorkflowActors (comma-separated; blank = default, "none" = explicit empty list). - Settings -> Features -> Auto-merge -> Workflow approval: a toggle and a text field with YAML hints and help, plus a search entry. - Admin MCP governor.feature_settings accepts both and discloses turning approval on and changing the trusted actors. - Both keys leave the parity allowlist. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Danathar this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (7 waiting): fixes are handed out before new work as soon as you have capacity. |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
Resolve the admin-MCP conflict with hivecommons#18948: keep both feature_settings tests and name both knob groups in the operation description. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#18953d480022` sha256:a9b6ca9cf95274748c7a5951ba4f101951fafd57a09f60e11b1c3d9b16e5af65 — download from the dashboard or `hivectl review evidence #18953`.merged by Hive trusted-author auto-merge: author |
Summary
governor.ci.auto_approve_workflowsandgovernor.ci.auto_approve_workflow_actors(from #16603) were yaml-only;settings_parity_allowlist.txtmarked both that way. So a hosted hive couldn't trust another bot without a config-file change. One example:github-actions[bot], for PRs a repository's own workflows open, such as metrics refreshes, promotions and ISO records. This PR gives both keys a Settings control and an admin-MCP write, and removes them from the allowlist. #16736, which added the keys, records no decision to keep them yaml-only.What it adds
ciAutoApproveWorkflowsis a boolean.ciAutoApproveWorkflowActorsis a comma-separated string, with the same convention asclaimsNeverClaimLabels. Blank restores the default (dependabot[bot], renovate[bot]), andnonestores an explicit[].governor.feature_settingsaccepts both fields. Its widening disclosure names turning approval on and any change to the trusted actors other thannone.operator-reference/runtime-and-quota.mdsays where both controls live.The approval sweep reads
cfg.Governor.CIevery cycle, so a change applies from the next eval cycle without a restart. The defaults are unchanged.Related
github-actions[bot]per hive; this PR makes that setting reachable from the dashboard.writeback.unsolicited.*fields to the same MCP op. The two edits touch different lines.Tests
TestGovernorFeaturesWorkflowApprovalRoundTrip: covers the flag and the list as typed, "none", blank (the default), and a refused login with whitespace.TestWorkflowApprovalSettingsRender: checks the YAML hint and the control binding.TestFeatureSettingsWorkflowApproval: checks the MCP body and the disclosure.The bundle was rebuilt from static-src.
gofmt -lis clean, andcheck-docs-citations.pyverified 2163 references. Per AGENTS.md, nothing was built or tested locally; CI decides.🤖 Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1