Skip to content

✨ settings: dashboard toggle and admin-MCP write for shared_ci_rerun.enabled - #19021

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:feat/shared-ci-rerun-setting
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:feat/shared-ci-rerun-setting

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary

shared_ci_rerun.enabled could only be changed by editing the config file. It was on the settings-parity allowlist as # TODO #11854. This PR adds a Settings toggle and an admin-MCP write for it, and removes the allowlist entry.

The reason it matters now: re-running failed jobs needs Actions: Read and write on the hive's App, and that permission is optional (src/docs/github-app-setup.md, "Optional shared-CI recovery"). A hive that doesn't grant it gets a 403 on every rerun-failed-jobs call and a note on each affected PR. Until now, the only way to stop those attempts was a config-file change, which a hosted hive's owner can't make.

What changed

  • Features API: PUT/GET /api/config/governor/features carries sharedCiRerunEnabled. The sweep reads the setting on every pass, so a change applies from the next sweep.
  • Settings: a new Shared-CI recovery block under Features → Quality loops & release health, with the toggle, a YAML-key hint, help text that names the optional permission, and a search entry.
  • Admin MCP: governor.feature_settings accepts sharedCiRerunEnabled. Turning it on is named in the widening disclosure; turning it off is not.
  • Docs: github-app-setup.md (how a hive without the permission turns the sweep off), the sweeps reference table, and admin-mcp.md.

This follows the pattern of #18953, which did the same for governor.ci's workflow-approval keys.

Tests

  • TestGovernorFeaturesSharedCIRerunRoundTrip covers:
    • the default is on;
    • the PUT turns it off;
    • the GET reports it;
    • an unrelated PUT leaves it alone;
    • the control renders with its YAML hint.
  • TestFeatureSettingsSharedCIRerun covers the MCP preview body and the disclosure in both directions.

Locally I ran only gofmt -l (AGENTS.md bans local go test/go build/go vet), the bundle regeneration, and check-docs-citations.py. CI is the test run.

Refs #11854

🤖 Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

…abled

shared_ci_rerun.enabled was yaml-only (settings_parity_allowlist.txt, TODO
hivecommons#11854). A hive whose App has no Actions write, an optional permission
(src/docs/github-app-setup.md), gets a 403 on every rerun-failed-jobs and a
note on each PR, and could only turn the sweep off by editing its config.

- Features PUT/GET: sharedCiRerunEnabled.
- Settings -> Features -> Quality loops & release health -> Shared-CI
  recovery: a toggle with a YAML hint and help, plus a search entry.
- Admin MCP governor.feature_settings accepts it and discloses turning it on.
- The key leaves the parity allowlist; docs updated.

Refs hivecommons#11854

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19015 ✨ auto-merge: an owner's approval of the head releases the human-merge-path hold (opt-in per repo) same files src/docs/admin-mcp.md
src/pkg/dashboard/static-src/js/config-features.js
src/pkg/dashboard/static/index.html

@hivecommons-hive
hivecommons-hive Bot merged commit ce50f47 into hivecommons:v6 Nov 18, 2026
85 of 86 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#19021e065b40` sha256:6f5429f7917860f4e56ae0f4c68964e438400cbe49a72e787401ff361a5b2601 — download from the dashboard or `hivectl review evidence #19021`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant