Repository navigation
✨ settings: dashboard toggle and admin-MCP write for shared_ci_rerun.enabled - #19021
Merged
hivecommons-hive[bot] merged 1 commit intoNov 18, 2026
Merged
Conversation
…abled shared_ci_rerun.enabled was yaml-only (settings_parity_allowlist.txt, TODO hivecommons#11854). A hive whose App has no Actions write, an optional permission (src/docs/github-app-setup.md), gets a 403 on every rerun-failed-jobs and a note on each PR, and could only turn the sweep off by editing its config. - Features PUT/GET: sharedCiRerunEnabled. - Settings -> Features -> Quality loops & release health -> Shared-CI recovery: a toggle with a YAML hint and help, plus a search entry. - Admin MCP governor.feature_settings accepts it and discloses turning it on. - The key leaves the parity allowlist; docs updated. Refs hivecommons#11854 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Nov 18, 2026
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared_ci_rerun.enabledcould only be changed by editing the config file. It was on the settings-parity allowlist as# TODO #11854. This PR adds a Settings toggle and an admin-MCP write for it, and removes the allowlist entry.The reason it matters now: re-running failed jobs needs Actions: Read and write on the hive's App, and that permission is optional (
src/docs/github-app-setup.md, "Optional shared-CI recovery"). A hive that doesn't grant it gets a 403 on everyrerun-failed-jobscall and a note on each affected PR. Until now, the only way to stop those attempts was a config-file change, which a hosted hive's owner can't make.What changed
PUT/GET /api/config/governor/featurescarriessharedCiRerunEnabled. The sweep reads the setting on every pass, so a change applies from the next sweep.governor.feature_settingsacceptssharedCiRerunEnabled. Turning it on is named in the widening disclosure; turning it off is not.github-app-setup.md(how a hive without the permission turns the sweep off), the sweeps reference table, andadmin-mcp.md.This follows the pattern of #18953, which did the same for
governor.ci's workflow-approval keys.Tests
TestGovernorFeaturesSharedCIRerunRoundTripcovers:TestFeatureSettingsSharedCIReruncovers the MCP preview body and the disclosure in both directions.Locally I ran only
gofmt -l(AGENTS.md bans localgo test/go build/go vet), the bundle regeneration, andcheck-docs-citations.py. CI is the test run.Refs #11854
🤖 Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1