Skip to content

✨ admin MCP: write the write-back unsolicited knobs through governor.feature_settings - #18948

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v6from
Danathar:feat/writeback-backfill-mcp-write
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v6from
Danathar:feat/writeback-backfill-mcp-write

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary

Three write-back containment settings had dashboard toggles but no admin-MCP write: writeback.unsolicited.backfill, require_labels and min_level. They sit under Settings → Features → Write-back containment. The admin MCP could only change the per-kind overrides, through writeback.kind_policy. This is the parity follow-up noted on #18846, which made backfill self-repair.

governor.feature_settings already wraps the same PUT /api/config/governor/features endpoint those toggles save through. It now also accepts writebackMinLevel, writebackRequireLabels and writebackBackfill. Nothing changes on the endpoint: it already validates the fields (for example, min_level must be 0 to the max ACMM level) and records the audit entry.

Disclosure

Each of these can let the hive write to items it wasn't asked to touch, so the preview's widening disclosure names:

  • writebackBackfill: true: unsolicited writes to PRs and issues created before the hive first saw the repo;
  • writebackRequireLabels: false: the review opt-in label is no longer required on other people's PRs;
  • any writebackMinLevel change: the ACMM floor moves (0 clears it).

Turning backfill off, or the label requirement on, is not reported as widening.

Not in this PR

writebackPerRepo (the per-repo mode map) still has no MCP write. It replaces the whole map, so it needs the read-merge-fingerprint pattern that writeback.kind_policy uses rather than a field in this op.

Tests

  • TestFeatureSettingsWritebackUnsolicited: the body carries all three fields, the disclosure names each, and turning backfill off is not reported as widening.
  • Docs: admin-mcp.md and design/admin-mcp.md.
  • gofmt -l is clean, and check-docs-citations.py verified 2163 references. Per AGENTS.md, nothing was built or tested locally; CI decides.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

…or.feature_settings

writeback.unsolicited.backfill, require_labels and min_level have
dashboard toggles (Settings -> Features -> Write-back containment) but no
admin-MCP write; only the per-kind overrides had one (writeback.kind_policy).
governor.feature_settings, which wraps the same PUT
/api/config/governor/features, now accepts writebackMinLevel,
writebackRequireLabels and writebackBackfill, and its widening disclosure
names backfill on, the opt-in label requirement off and any level change.

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch is behind the base and Hive cannot update it; enable "allow edits by maintainers" or rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity.

@Danathar Danathar changed the title feat(adminmcp): write the write-back unsolicited knobs through governor.feature_settings ✨ admin MCP: write the write-back unsolicited knobs through governor.feature_settings Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18953 ✨ dashboard: Settings control and MCP write for governor.ci workflow approval CONFLICT src/pkg/adminmcp/adminmcp_test.go (conflict)
src/pkg/adminmcp/tools_fleet_ops.go (conflict)

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@clubanderson clubanderson added the author/human A person pushed this PR themselves label Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review at 8c445ce. The three new fields (writebackMinLevel, writebackRequireLabels, writebackBackfill) match the json tags in src/pkg/dashboard/api_governor_features_platform.go:67-69. The endpoint handles them at lines 234-254, including the 0 to MaxACMMLevel range check. The int and bool schemas and the preview body pass them through unchanged, so the wiring is correct. The test covers the body and the disclosure, and checks that turning backfill off is not flagged as widening.

One low-severity advisory, which does not block: the writebackMinLevel disclosure overstates the effect (inline comment).

— hive: agent=adjudicator-3 backend=claude model=claude-sonnet-5-5 claude=2.1.327

Comment thread src/pkg/adminmcp/tools_fleet_ops.go Resolved
The level only raises per-kind floors, and 0 restores the default
(review on hivecommons#18948).

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@hivecommons-hive
hivecommons-hive Bot merged commit eafa6f7 into hivecommons:v6 Nov 18, 2026
71 of 72 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1894882c87f7` sha256:ec9eb76368ddd2871df973baa7b0df732ef0176f8e3b1a5d5d15e61a278a7b00 — download from the dashboard or `hivectl review evidence #18948`.

Danathar added a commit to Danathar/hive that referenced this pull request Nov 18, 2026
Resolve the admin-MCP conflict with hivecommons#18948: keep both feature_settings
tests and name both knob groups in the operation description.

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants