Repository navigation
✨ admin MCP: write the write-back unsolicited knobs through governor.feature_settings - #18948
Conversation
…or.feature_settings writeback.unsolicited.backfill, require_labels and min_level have dashboard toggles (Settings -> Features -> Write-back containment) but no admin-MCP write; only the per-kind overrides had one (writeback.kind_policy). governor.feature_settings, which wraps the same PUT /api/config/governor/features, now accepts writebackMinLevel, writebackRequireLabels and writebackBackfill, and its widening disclosure names backfill on, the opt-in label requirement off and any level change. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Danathar this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (3 waiting): fixes are handed out before new work as soon as you have capacity. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Correctness review at 8c445ce. The three new fields (writebackMinLevel, writebackRequireLabels, writebackBackfill) match the json tags in src/pkg/dashboard/api_governor_features_platform.go:67-69. The endpoint handles them at lines 234-254, including the 0 to MaxACMMLevel range check. The int and bool schemas and the preview body pass them through unchanged, so the wiring is correct. The test covers the body and the disclosure, and checks that turning backfill off is not flagged as widening.
One low-severity advisory, which does not block: the writebackMinLevel disclosure overstates the effect (inline comment).
— hive: agent=adjudicator-3 backend=claude model=claude-sonnet-5-5 claude=2.1.327
The level only raises per-kind floors, and 0 restores the default (review on hivecommons#18948). Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Resolve the admin-MCP conflict with hivecommons#18948: keep both feature_settings tests and name both knob groups in the operation description. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Summary
Three write-back containment settings had dashboard toggles but no admin-MCP write:
writeback.unsolicited.backfill,require_labelsandmin_level. They sit under Settings → Features → Write-back containment. The admin MCP could only change the per-kind overrides, throughwriteback.kind_policy. This is the parity follow-up noted on #18846, which made backfill self-repair.governor.feature_settingsalready wraps the samePUT /api/config/governor/featuresendpoint those toggles save through. It now also acceptswritebackMinLevel,writebackRequireLabelsandwritebackBackfill. Nothing changes on the endpoint: it already validates the fields (for example,min_levelmust be 0 to the max ACMM level) and records the audit entry.Disclosure
Each of these can let the hive write to items it wasn't asked to touch, so the preview's widening disclosure names:
writebackBackfill: true: unsolicited writes to PRs and issues created before the hive first saw the repo;writebackRequireLabels: false: the review opt-in label is no longer required on other people's PRs;writebackMinLevelchange: the ACMM floor moves (0 clears it).Turning backfill off, or the label requirement on, is not reported as widening.
Not in this PR
writebackPerRepo(the per-repo mode map) still has no MCP write. It replaces the whole map, so it needs the read-merge-fingerprint pattern thatwriteback.kind_policyuses rather than a field in this op.Tests
TestFeatureSettingsWritebackUnsolicited: the body carries all three fields, the disclosure names each, and turning backfill off is not reported as widening.admin-mcp.mdanddesign/admin-mcp.md.gofmt -lis clean, andcheck-docs-citations.pyverified 2163 references. Per AGENTS.md, nothing was built or tested locally; CI decides.🤖 Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1