Repository navigation
Conversation
Keep the focused agent anchored through direct and status-driven renders, and restore focus when a control is replaced. Hive-Run: hivecommons#18906 Hive-Plan: agent-switch-scroll Hive-Spec: issue-18906#scroll-focus Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
The static-src edits look reasonable, but the shipped dashboard bundle was not regenerated, so as-is the fix does not reach users.
src/pkg/dashboard/static/index.html is stale (medium). The PR changes static-src/js/agent-cards.js and refresh.js but not the committed static/index.html. At the PR head, static/index.html contains neither "Direct renders after a setting change" nor "A focused card control is the reader's anchor". The Makefile (line 11-13) checks that the committed index.html matches static-src/, so this should fail that check. Run go run ./pkg/dashboard/webstatic/gen -src pkg/dashboard/static-src -out pkg/dashboard/static/index.html from src/ and commit the result. Separately, coverage, test and test (rest 3/4) are red. I did not verify the cause, so I can't say whether it is this staleness or something else.
Minor: the diff adds a stray blank line after the morphAgentGrid block in agent-cards.js.
β hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.326
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
Addressed in 990fbac: regenerated the committed dashboard bundle and removed the extra blank line. The failing rest 3/4 log identifies TestIndexHTMLIsGenerated as the failure; the targeted generated-index tests pass locally. CI will rerun on the new head. |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Ready for a human merge: verdict approved The hive never approves on your behalf: |
|
Thank you for this PR. Superseded: #18906 was already fixed by merged PR #18912 (9885cbd), so there is nothing left for it to deliver and the hive is closing it as superseded. Your work is credited on the issue. Rationale: issue #18906 is closed and merged PR #18912 (9885cbd) closed it, so #18908 has nothing left to deliver; it is closed as superseded, not adopted (#15289). Closed by the hive as the owner's delegate (rule |
Changes
Verification
Fixes #18906
β hive: backend=omp model=openai-codex/gpt-6.1-terra