Repository navigation
π stage: the 085 note stops asking for an approval the head already has - #18849
Merged
hivecommons-hive[bot] merged 1 commit intoNov 17, 2026
Merged
Conversation
A lane that stops at an earlier gate (a fork-guard check, a hold) never reaches the review gate or the workflow fence, so nothing notes the trusted approval on the head. The 085 note then kept listing the reviewer's requires_human question and the fence "awaiting owner approval", and asked a trusted merger to approve the head again (projectbluefin/utah-packages#1181, hivecommons#1013). humanEvidence now reads the head's trusted approval when the route would ask for one and no lane noted it (cached per head for humanChecksTTL), routeProgress drops the workflow-path fence the approval released, and the same-head 085 re-park reads it before re-asking the answered question. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Nov 17, 2026
Contributor
hivecommons-hive Bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
#18950) * fix(dashboard): 085 row stops asking for an approval the head has At 085 the Activity monitor learned a head's trusted approver only from the `:human-approved@` reason suffix, which is written at 090. A head a trusted merger approved but that stays at 085 for another blocker (projectbluefin/utah-packages#1013: fork-guard:Canary) kept showing the reviewer's requires_human question and an enabled Approve. - The stage pass records the head's trusted approval it found (obs.Detail.HumanApprover for the head) on the stage record: Record.ApprovedHead / ApprovedBy, display evidence only. - The tracker row reads it at 085 when the reason carries no approver. - decisionForPR skips the reviewer question the approval answered and disables Approve with the approver named, except on a sentinel alert, where Approve also clears the label. Follow-up to #18849. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 * test(dashboard): type-assert the open-PR entry before moving its head OpenPrs holds any; vet refused the field access. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the lane stops at an earlier gate (a fork-guard check, a hold), the 085 "Needs a decision" note keeps asking for an owner approval the head already has. It lists:
requires_humanquestion;All of that appears even though a trusted maintainer approved that exact head, and the hive itself posted that the approval released the fence.
With this change, the stage pass reads the head's trusted approval itself in that case. The note then names only what is actually left (here the fork guard), and What to do says "nothing more to approve: @x approved this head".
What happened
Seen on projectbluefin/utah-packages#1181 (11-17, Eastern). It is a fork PR that edits workflows, and its required
Canarycheck refuses fork PRs.11352dc.requires_humanquestion.Canary), it still listsrequires_human, the reviewer's question and "awaiting owner approval", and asks a trusted merger to approve the head.projectbluefin/utah-packages#1013 has the same shape (11-16 approval, 11-17 1:51 PM note on the same head).
This is not the empty-note bug fixed in #18669. Here the note names causes that are already settled.
Cause
There are two gaps, and both are needed for the wrong note.
humanEvidencetakes the approver only from the per-passobs.Detail.HumanApprover.fork-guard:<check>reaches neither, so the route listsrequires_humanand takes the "a trusted merger approves this head" branch ofDecisionActions.preserveNeedsDecisionOnSameHeadβsameHeadDecisionRoute, added in π stage: the 085 needs-decision comment always names a causeΒ #18669) builds its reasons from the verdict with no approver check, so it has the same gap.routeProgressdrops the fence cause only on the manual-merge path (manualMergeApproved, which needsManualMergeRule).What changed
humanEvidence: when the route would ask for an approval (requires_humanverdict, or a fence the approval releases) and no lane noted one, it reads the head's trusted approval viaheadTrustedApproval:requires_humana recorded/hive decision approve;humanChecksTTL(10 minutes), like the head's checks.sameHeadApproved). An approved head is not re-parked on the question the approval answered.sameHeadDecisionRoutealso skips therequires_humanreasons when the head carries an approval.routeProgress: a newEvidence.CauseAwaitsApprovalmarks the fence-awaiting-approval cause. With an approver set, that cause is no longer listed, and "the automerge lane will not merge this unattended" doesn't stand in for it.owner_approval_releases_workflow_fenceoff) is unchanged: an approved head is still a person's merge at 090.docs/hive-merge.mdand a changelog fragment.What counts as an approval is unchanged, and so is the fork-guard and sentinel wording.
Not in this PR
human_approver, the offered reviewer question, Approve enabled). The dashboard takeshuman_approveronly from the:human-approved@reason suffix, which is written at 090. At 085 it shows no approver even when a lane did note one, so that is a separate dashboard change.Canaryat all. That is repo policy.Tests
stagelabels/human_approved_fence_test.go:automerge/automerge_stage_human_approved_head_test.go:humanEvidencewith a fork-guard observation reads @bob's approval from a stubbed reviews endpoint;sameHeadApproved/sameHeadDecisionRoutewith and without an approval.Only
gofmt -lwas run locally (AGENTS.md bans localgo test/go build/go vet); this PR's CI is the test run.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1