Repository navigation
π adoption: a red optional check escalates where auto-merge is off - #18847
Merged
hivecommons-hive[bot] merged 1 commit intoNov 17, 2026
Conversation
The stall escape never counted a red optional check (hivecommons#13040: the lane merges past it, so nothing is a person's to decide). On a repo whose auto-merge is off the lane only observes and a person merges, so an adopted PR red only on an optional check sat at 074 with nothing for the hive to push and nobody asked (projectbluefin/actions#752, 35h). Count it there like any other red check: past the 074 dwell with CI idle it escalates to 085 adoption-stalled:optional-check-failing:<check>, and the note says the check is optional and a person may merge past it. Where the hive merges, the hivecommons#13040 exclusion is unchanged. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Nov 17, 2026
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
This was referenced Nov 17, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a repo whose auto-merge is off, an adopted PR that is red only on an optional check now moves to
stage/085-needs-decisiononce it sits idle past the 074 dwell. Before this change it stayed atstage/074-adopted-by-hiveindefinitely: the hive had nothing to push and nobody was asked.Where the hive merges, nothing changes. The #13040 rule still holds there: a red optional check alone never escalates.
What happened
projectbluefin/actions#752, a clanker's fork PR in a repo with auto-merge off (knuckle, build
3b50113):85 β 74with reasonoptional-check-failing:Check consumer validation evidence.finisherisperson("auto-merge is off for this repo β¦ a person merges it"), and the PR is not inwaiting_on_human.The red check needs a maintainer-supplied consumer run, which neither the fixer nor the author can produce. The 074 dwell is 12h. The PR sat 35h past it on an unchanged head.
Cause
stage-labels.md:1072-1076).adoptionStalledReasonWithreturns""whenadoptionOptionalCheckOnly(obs)is true (automerge_contributor_adopt.go:2601on98f201ddd). Its reason, from π adopted PR escalated to 085 minutes after a hive push: legacy records lack adopted_head_at, optional-check red counts as stalled, escalation never releasesΒ #13040, is that "the merge gate does not read it, so it is nothing a person must decide".derive_pr_classify.go:634-641).repo-auto-merge-disabled(automerge_observe_only.go:93-108), and a person merges.What changed
adoptionOptionalCheckOnlyno longer applies when the lane only observed the head (LaneReason == repo-auto-merge-disabled, via a newadoptionLaneObservedOnlyhelper). In that case the red optional check escalates like any other red check: after the 074 dwell, on an unchanged head with CI idle, the PR moves to 085 with reasonadoption-stalled:optional-check-failing:<check>.stage-labels.md(the 074 row, the transition diagram, and the stall paragraph) andhive-merge.mdnow describe the exception.Why this rule rather than not adopting
I kept #13040's owner rule where its premise holds and only exempted the one case where it doesn't, so this doesn't reverse an owner decision. The prompt's other option, never adopting on an optional-only red, would leave #752 at 072 waiting on an author who cannot act. That is the same deadlock one stage earlier.
Not in this PR
Check consumer validation evidenceshould be required in projectbluefin/actions. That is the repo's call.Tests
TestAdoptionEscapeHelpers: three new rows on an auto-merge-off repo.adoption-stalled:optional-check-failing:consumer.no-verdict) is unchanged, so repos where the hive merges keep π adopted PR escalated to 085 minutes after a hive push: legacy records lack adopted_head_at, optional-check red counts as stalled, escalation never releasesΒ #13040's behavior.TestAdoptionStalledCommentOptionalCheckAutoMergeOff: the note names the optional check and "merge past it" on an auto-merge-off repo. It does not offer that when the stall reason is a required check, and it does not say "auto-merge is off" on a repo where the hive merges.Only
gofmt -lwas run locally (AGENTS.md bans localgo test/go build/go vet). This PR's CI is the test run.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1