Repository navigation
π dashboard: 085 row stops asking for an approval the head already has - #18950
hivecommons-hive[bot] merged 2 commits into
Conversation
At 085 the Activity monitor learned a head's trusted approver only from the `:human-approved@` reason suffix, which is written at 090. A head a trusted merger approved but that stays at 085 for another blocker (projectbluefin/utah-packages#1013: fork-guard:Canary) kept showing the reviewer's requires_human question and an enabled Approve. - The stage pass records the head's trusted approval it found (obs.Detail.HumanApprover for the head) on the stage record: Record.ApprovedHead / ApprovedBy, display evidence only. - The tracker row reads it at 085 when the reason carries no approver. - decisionForPR skips the reviewer question the approval answered and disables Approve with the approver named, except on a sentinel alert, where Approve also clears the label. Follow-up to hivecommons#18849. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Danathar this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (6 waiting): fixes are handed out before new work as soon as you have capacity. |
OpenPrs holds any; vet refused the field access. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Summary
A PR can sit at 085 for some other reason after a trusted merger has already approved its head. The Activity monitor row still asks for that approval: it shows the reviewer's
requires_humanquestion and an enabled Approve.With this change, the stage pass records the head's trusted approval on the stage record. The 085 row reads it from there and does three things:
This is the dashboard follow-up noted on #18849.
What happened
projectbluefin/utah-packages#1013, live on the board at 6:40 AM EST, 11-18:
fork-guard:Canary.4b9cac9, approved on GitHub by a trusted maintainer.#18849 fixed the 085 comment for this case. The row is still wrong because the dashboard learns
human_approveronly from the:human-approved@reason suffix, which is written at 090. At 085 the reason isfork-guard:Canary, and the approval the stage pass read (obs.Detail.HumanApprover) was never persisted.What changed
Record.ApprovedHead/ApprovedBy, set byStore.NoteHeadApproval. The stage pass writes them when the head's trusted approval is known, whether a lane noted it or the 085 route read it (headTrustedApproval, π stage: the 085 note stops asking for an approval the head already hasΒ #18849).AdmittedBy, and no lane reads it.Record.HeadApprover(head)returns nothing once the head moves.human_approvercomes from the record for the current head.decisionForPR). With an approver on the row:Tests
stage_tracker_085_approved_test.go:buildStageTracker: the recorded approval reaches the 085 row, and a new head does not inherit it.store_head_approval_test.go:NoteHeadApprovalandHeadApprover, covering a missing record, empty head or login, head match, and case.Locally I ran only
gofmt -l, since AGENTS.md bans localgo test/go build/go vet. CI is the test run.Not in this PR
π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1