Skip to content

πŸ› Sandbox Jobs keep their service account's imagePullSecrets - #18820

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
fix/18819-job-pull-secrets
Nov 17, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
fix/18819-job-pull-secrets

Conversation

@clubanderson

Copy link
Copy Markdown
Member

The Job pod's imagePullSecrets are now the deduplicated, order-stable union of the hive pod's secrets, the Job service account's imagePullSecrets (read via get serviceaccounts; skipped with a warning when denied, never an error) and the new sandbox.job.image_pull_secrets (names only, DNS-1123, max 32; a per-agent block that sets none inherits the global list). Only names are read or logged.

  • Boot/reload warning when service_account is set with no image_pull_secrets, and when names are invalid.
  • RBAC: serviceaccounts get added to the standalone Role and the hub-provisioned hive-sandbox-jobs Role (existing spokes keep working without it).
  • API: sandboxJob.imagePullSecrets accepted per agent. The dashboard UI field is left for a follow-up (parity allowlist entries added).
  • Not done: the early image_pull_failed kick failure (covered by ✨ Sandbox Jobs: pre-run node health check (sandbox.preflight) and fail-fast on an unschedulable JobΒ #18811).
  • Tests, docs (sandbox-isolation.md, agent-configuration.md), changelog.d fragment included.

Fixes #18819

πŸ€– Generated with Claude Code

…dbox.job.image_pull_secrets (#18819)

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18805 πŸ› config: adopt review and agent_sandbox from the dashboard overlay on reload same files src/docs/agent-configuration.md
src/pkg/config/config.go

…size ratchet)

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson changed the title πŸ› Sandbox Jobs keep their service account's imagePullSecrets (#18819) πŸ› Sandbox Jobs keep their service account's imagePullSecrets Nov 17, 2026
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

ℹ️ Sentinel: informational, author is trusted (owner), merge is not blocked. Head d3c8d45787de matched:

  • sensitive_path: changes 1 sensitive path(s) (src/deploy/k8s/sandbox-job-rbac.yaml)

No sentinel-alert label was added. The finding is recorded in the dashboard Security tab and /api/sentinel; set sentinel.trusted_authors_block: true to block trusted authors too.

Evidence bundle `#18820d3c8d45` sha256:3f9a237a147da53df6a577d9adffd985a72efbab2be899a0a32c98a57850107d β€” download from the dashboard or `hivectl review evidence #18820`.

merged by Hive trusted-author auto-merge: author clubanderson holds role owner and GitHub permission admin on repo; CI green at d3c8d45.

@hivecommons-hive
hivecommons-hive Bot merged commit 74ea349 into v5 Nov 17, 2026
95 of 96 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/18819-job-pull-secrets branch November 17, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

1 participant