Repository navigation
π Sandbox Jobs keep their service account's imagePullSecrets - #18820
Conversation
β¦dbox.job.image_pull_secrets (#18819) Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
β¦size ratchet) Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. βΉοΈ Sentinel: informational, author is trusted (owner), merge is not blocked. Head
No merged by Hive trusted-author auto-merge: author |
The Job pod's imagePullSecrets are now the deduplicated, order-stable union of the hive pod's secrets, the Job service account's imagePullSecrets (read via
get serviceaccounts; skipped with a warning when denied, never an error) and the newsandbox.job.image_pull_secrets(names only, DNS-1123, max 32; a per-agent block that sets none inherits the global list). Only names are read or logged.service_accountis set with noimage_pull_secrets, and when names are invalid.serviceaccounts getadded to the standalone Role and the hub-provisionedhive-sandbox-jobsRole (existing spokes keep working without it).sandboxJob.imagePullSecretsaccepted per agent. The dashboard UI field is left for a follow-up (parity allowlist entries added).image_pull_failedkick failure (covered by β¨ Sandbox Jobs: pre-run node health check (sandbox.preflight) and fail-fast on an unschedulable JobΒ #18811).Fixes #18819
π€ Generated with Claude Code