Repository navigation
✨ Customers: agent context block and a people retriever for the meeting persona - #18794
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
…eople retriever for the persona PR 7 of RFC #18742. - customers.RenderKickContext and PeopleBriefs: login, active tags, confirmed goals and a count; never an email, an id, notes or the satisfaction assessment. Goals are scanned with ioscan, dropped whole on an address, an id or a finding, and fenced with a fresh nonce. The kick block is capped at 1,024 bytes. - scheduler: a CustomerContextLookup seam after the maintainer notes; the scheduler never imports the customers package. - betty: PeopleRetriever over a PeopleDirectory; cmd/hive supplies it. - security-model.md and the design page describe the boundary. Refs #18742 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Refs #18742 Signed-off-by: Andy Anderson <andy@clubanderson.com>
77db0b0 to
e777fae
Compare
Mutation testinggremlins found 14 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
2 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
PR 7 of the Customers series (RFC #18742). This crosses a security boundary, so the rules are listed first and each has a test. It does not depend on PR 6 (#18791).
What it does
# Customer contextblock after the maintainer notes: their GitHub login, the tags that are on, up to three goals a person confirmed, and a count.PeopleRetriever. When a question names a customer (a word equal to a word of their name, or their login), the persona can describe them.Agents still cannot query the customers store (
security-model.mdsection 4, ADR-0011). They receive this slice and nothing else.Rules and where they are tested
TestRenderKickContextHonoursTheCapAtEverySizeTestKickContextOnlyCustomersAndNothingPrivateioscan, dropped whole on an address, an id or a finding; control characters removedTestSafeGoalTestKickContextInjectionStringsTestRenderKickContextShapeAndFenceTestKickCustomerContext*TestPeopleRetriever,TestPeopleBriefsForThePersona,TestCustomersAgentContextWiringDecisions
pkg/customers. The scheduler takes afunc(logins []string) string; Betty takes aPeopleDirectoryinterface;cmd/hiveconnects them.Docs:
security-model.md(agents section) and the design page.Refs #18742
🤖 Generated with Claude Code