Repository navigation
🐛 Meetings: don't restart-loop the Spektacular stream child when live mode isn't available - #18633
clubanderson wants to merge 1 commit into
Conversation
… mode isn't available The pinned spektacular (0.31.0) has no `meeting` command (hivecommons/spektacular#126 is unreleased), so every live meeting child printed cobra's unknown-command envelope and exited 1. The stream restarted it five times per meeting, each restart a WARN, which the slog feed self-reported as unclassified_error_repeated (#18630), and the session warned once per transcript line it could not forward. - spektacular.Stream gains an optional Probe (`meeting --help`), run once per installed binary; an unknown command marks the stream Unsupported: no child is started or restarted, one INFO line per binary. A child whose own exit output says unknown command is not restarted either. - Restart lines are WARN at most once per BackoffMax window (INFO otherwise) and map to a new log-fed class spek_stream_unavailable. - The live session treats an unsupported Spek as off from the start (panel status unchanged), stops forwarding once Spek is gone, and warns about a failed forward only on the transition to paused. Fixes #18630 Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testing1 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
Combined into #18635 to get through CI and review together. |
Fixes #18630
Root cause
The hive image pins spektacular 0.31.0, which has no
meetingcommand (live meeting mode is hivecommons/spektacular#126, still open). Each live meeting'sspektacular meeting --from stdin ...child printed cobra'sunknown command "meeting"inside the CLI's indented JSON error envelope on stdout and exited 1.spektacular.Streamrestarted it with backoff (1s, 2s, 4s, 8s, 16s), logging[spektacular] stream child exited; restartingat WARN each time: 5 in 10 minutes, which the slog feed filed asunclassified_error_repeated. Pod logs on the reporting hive show exactly that series, plus sixspek wrote a non-JSON linewarnings per restart (the envelope lines) andforwarding to spek ... stream child is not runningfor transcript lines.Fix
spektacular.StreamOptions.Probe: the meetings wiring probesspektacular meeting --helponce per installed binary (cached by path, size and mtime). An unknown-command answer marks the streamUnsupported:Startreturns nil with the stream already done, no child is started or restarted, and one INFO line is logged per binary. As a fallback, a child whose own exit output says unknown command is not restarted either.BackoffMaxwindow (INFO otherwise) and is classified by the new log-fed classspek_stream_unavailableinstead ofunclassified_error_repeated.Tests
pkg/spektacular: probe-unsupported never starts a child and probes once; unknown-command exit is not restarted; probe-supported starts normally; restart WARN once per backoff window.pkg/meetings/live: unsupported Spek gets no forwarded lines and no warnings; forwarding failure warns once per outage.pkg/fleetreport: the new class in the threshold and log-fed classification tables.Changelog:
changelog.d/fixed-18630-spek-stream-restart-loop.md. Docs: class row insrc/docs/fleet-report.md.🤖 Generated with Claude Code